Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Fedora32 with python3.8 #3

Closed
wernermaes opened this issue Oct 30, 2020 · 6 comments · Fixed by #4
Closed

Does not work on Fedora32 with python3.8 #3

wernermaes opened this issue Oct 30, 2020 · 6 comments · Fixed by #4

Comments

@wernermaes
Copy link

Hello

It is possible to make it work on Fedora32 and python3.8?

@tfga
Copy link
Owner

tfga commented Oct 30, 2020 via email

@wernermaes
Copy link
Author

Hello

I made it work.
Will post the details here in a minute

@wernermaes
Copy link
Author

wernermaes commented Oct 30, 2020

python3 print is a function, so it should use print("hello") instead of print "hello"
also I needed to change the install script to use python3 (since I don't have dbus module in python2.7). Fedora32 install python3-dbus

in install script:

virtualenv --clear -p python3 --system-site-packages .venv

created file /pidginCli/.venv/lib/python3.8/site-packages/PidginCli/ArgParser.py

print (args)

created file /pidginCli/.venv/lib/python3.8/site-packages/PidginCli/pidginCli.py

elif lenAccounts > 1:

    print ('WARNING: More than one account found. Using the first one.')

    for a in accounts:

        print ('a, purple.PurpleAccountGetUsername(a)')

@tfga
Copy link
Owner

tfga commented Oct 31, 2020

Thanks for the feedback.

What is the actual command line for installing python3-dbus on Fedora? I'm updating README.

If I created a branch with your modifications, would you be willing to test it before I merge it into master?

Did you run into any other issues?

@wernermaes
Copy link
Author

@tfga

dnf install python3-dbus is the command.
I'm willing to test it.
For the moment I only tried sending a message to several users, which worked fine.

Kind regards

tfga added a commit that referenced this issue Nov 2, 2020
tfga added a commit that referenced this issue Nov 2, 2020
tfga added a commit that referenced this issue Nov 2, 2020
@tfga
Copy link
Owner

tfga commented Nov 2, 2020

@wernermaes

Great! 😄

Here the branch: Fedora32.

I modified README, install and the python code. If you could go through the installation procedure once again (when you have the time, ofc) and let me know how it went, it would be great. 👍

@tfga tfga mentioned this issue Nov 9, 2020
@tfga tfga closed this as completed in #4 Nov 9, 2020
tfga added a commit that referenced this issue Nov 9, 2020
tfga added a commit that referenced this issue Nov 9, 2020
tfga added a commit that referenced this issue Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants