Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute Field::filter() in Field::validate() #21

Merged
merged 4 commits into from Apr 15, 2018
Merged

Conversation

tflori
Copy link
Owner

@tflori tflori commented Apr 15, 2018

This ensures that the value given is filtered before it get's validated.
Beside that Field::filter() gets now executed twice what is acceptable
because filters caches (when possible) the filtered value.

This ensures that the value given is filtered before it get's validated.
Beside that `Field::filter()` gets now executed twice what is acceptable
because filters caches (when possible) the filtered value.
@coveralls
Copy link

coveralls commented Apr 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b9eda60 on fix/always-filter into c2ec67e on master.

@tflori tflori merged commit e3a7af5 into master Apr 15, 2018
@tflori tflori deleted the fix/always-filter branch April 15, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants