Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch covers from the internet in portrait is not usable #12

Closed
maverick74 opened this issue May 16, 2023 · 3 comments
Closed

Fetch covers from the internet in portrait is not usable #12

maverick74 opened this issue May 16, 2023 · 3 comments
Assignees
@tfonteyn
Labels
bug Something isn't working

Comments

@maverick74
Copy link
Contributor

Fetching covers from the internet in portrait mode is not usable as the popup is "too slim"
(landscape mode is OK)

Screenshot_2023-05-16-20-33-59-838_com hardbacknutter nevertoomanybooks
tfonteyn pushed a commit that referenced this issue May 16, 2023
fix github #12; the cover browser is now fullscreen on medium screens…
4dc8223 
…. This eliminates the tweaking of the minimum width which was never fully reliable.
@tfonteyn
Copy link
Owner

I should have seen this issue coming as I had the same issue for some other dialogs. I've just fixed this one as well now.
It's to late tonight, but you can expect a new release tomorrow.

A bit of an explanation: I tried to implement dialogs in such a way that they are automatically full-screen or a real-dialog depending on screen size. I've started to admit defeat... there are just to many different types of screen out there.
I'm more or less settling now on full-screen dialogs for all devices which have a diagonal of less than 7", and real-dialog style for 7" and larger screens.

@tfonteyn tfonteyn self-assigned this May 16, 2023
@tfonteyn tfonteyn added the bug Something isn't working label May 16, 2023
@maverick74
Copy link
Contributor Author

I'm more or less settling now on full-screen dialogs for all devices which have a diagonal of less than 7", and real-dialog style for 7" and larger screens.

Seems a good approach!

tfonteyn pushed a commit that referenced this issue May 17, 2023
fix github #12; the cover browser is now fullscreen on medium screens…
97e277d 
…. This eliminates the tweaking of the minimum width which was never fully reliable.
tfonteyn pushed a commit that referenced this issue May 17, 2023
patch 4.3.5 with fix for #12
44bc35a
@tfonteyn
Copy link
Owner

and another bug fixed: v4.3.5

@Geo5 Geo5 mentioned this issue Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfonteyn tfonteyn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfonteyn @maverick74