Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Response Code for post is 200? #428

Closed
li-darren opened this issue Jun 11, 2021 · 4 comments
Closed

Default Response Code for post is 200? #428

li-darren opened this issue Jun 11, 2021 · 4 comments
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending

Comments

@li-darren
Copy link

Describe the bug
When annotating a generics.createAPIView or generics.ListCreateAPIView, it seems as if the default response code for post responses is 200. Should it be 201? I am using drf spectacular auto schema and generator.

To Reproduce
Create a class that derives from generics.ListCreateAPIView and look at the post method response.

Expected behavior
The default response should be 201.

@tfranzel tfranzel added bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending labels Jun 12, 2021
@tfranzel
Copy link
Owner

hi! you are absolutely right. generally its tricky do guess the right response code, but here it's rather straight-forward. thanks for reporting.

@tfranzel
Copy link
Owner

closing this issue for now. feel free to comment if anything is missing or not working and we will follow-up.

@li-darren
Copy link
Author

Hey I was wondering, is there a release schedule or if you know when we can expect to be able to use this new feature?

@tfranzel
Copy link
Owner

tfranzel commented Jul 8, 2021

this has been released a month ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending
Projects
None yet
Development

No branches or pull requests

2 participants