Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't close notifications #9

Closed
xdaniel2063 opened this issue Aug 29, 2017 · 6 comments
Closed

can't close notifications #9

xdaniel2063 opened this issue Aug 29, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@xdaniel2063
Copy link

Hello,

me again. I mentioned on several installation that I can't close some notification when Dobby is activated. For example like the one attached.

When I disable Dobby I can close them.

Best wishes

Daniel

2017-08-29 20_18_58-plugins celtic-rock de wordpress

@tfrommen tfrommen added the bug label Aug 29, 2017
@tfrommen
Copy link
Owner

tfrommen commented Aug 29, 2017

Hi Daniel,

I'm pretty confident this is due to event listeners having been added to specific elements (e.g., via their ID), instead of adding them, for example, to the body element and then use delegation.

Unfortunately, I don't have the time to look into this before next week.
I hope I can get around the issue by not moving the captured elements in the DOM, but actually wrapping them in Dobby's closet directly, meaning rendering the opening and closing tags separately as first and last things in the admin notice area...

I'll keep you up to date.

@tfrommen
Copy link
Owner

tfrommen commented Sep 15, 2017

Hi Daniel,

I finally had some time to dig into this. Can you please check if the new branch, issue_9, is working for you?

The branch already contains a dismissible ERROR! notice for testing purposes, but please also test this with the notice(s) you had problems with before.

Thanks a lot in advance,
Thorsten

@tfrommen tfrommen added this to the 1.3.0 milestone Sep 15, 2017
@xdaniel2063
Copy link
Author

Hello Thorsten,

at the moment there are no more of these messages, but I'll have a look on it the next days and come back. Thanks for your work.

Best, Daniel

@xdaniel2063
Copy link
Author

Hello Thorsten, tested it on a different installation and comet cache messages. Closing them worked fine now. Best, Daniel

@tfrommen
Copy link
Owner

Great! Thanks for reporting back.

I'll release a new version later today, or tomorrow.

@tfrommen
Copy link
Owner

Fixed in d0edcd5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants