Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when opening file with no shared strings #34

Closed
degaart opened this issue Dec 22, 2015 · 2 comments
Closed

Error when opening file with no shared strings #34

degaart opened this issue Dec 22, 2015 · 2 comments

Comments

@degaart
Copy link

degaart commented Dec 22, 2015

If a spreadsheet has no shared strings (it's rare, but excel can produce such files), an exception is thrown in shared_strings_serializer::read_shared_strings() Specifically, it's on the line:

auto unique_count = std::stoull(root_node.get_attribute("uniqueCount"));

The solution would be to check if root_node has an "uniqueCount" attribute, else we consider unique_count to be zero.

I can produce a pull request if you want

@tfussell
Copy link
Owner

Interesting. I should have had a check for that. Thanks for reporting the issue. I'll try to get it sorted soon.

tfussell added a commit that referenced this issue Dec 22, 2015
tfussell added a commit that referenced this issue Dec 22, 2015
@tfussell
Copy link
Owner

This should be fixed now. Let me know if you have any more problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants