Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting strikethrough text in cell not working #530

Open
guitarflow opened this issue Dec 7, 2020 · 2 comments
Open

Detecting strikethrough text in cell not working #530

guitarflow opened this issue Dec 7, 2020 · 2 comments

Comments

@guitarflow
Copy link

Thanks for making this great library!

We'd like to use it to read and write Excel files with rich text (italic, bold, strikethrough...).
Detecting rich text attributes works per se.
However, when strikethrough or italic text formatting is used in cells, the attributes are either not extracted properly or we're getting corrupt file alerts.

Is there any chance to make this work?

Thanks and best regards in advance!

@guitarflow
Copy link
Author

excel_test_sheet.xlsx

tfussell added a commit that referenced this issue Feb 21, 2021
@tfussell
Copy link
Owner

tfussell commented Feb 21, 2021

Thanks for providing the relevant workbook. I added it to the test suite and fixed reading of strikethrough. I still get a broken workbook if I round trip it (read then write) so I'll see if I can figure out what's going on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants