-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ARM architecture #52
Conversation
Ideally, I think |
libexec/tfenv-install
Outdated
;; | ||
*) | ||
os="linux_amd64" | ||
TFENV_ARCH=${TFENV_ARCH:-amd64} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this line before the case
statement (L51). Currently os
ends up invalid because TFENV_ARCH
is not defined when OS is not Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
And please merge this commit into your branch by rebase or cherry-pick because some tests will fail without it, thanks. |
rebased against upstream master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Add support for arm, for us masochists.