Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with terraform alpha versions #94

Merged
merged 2 commits into from Feb 8, 2019

Conversation

iamhsa
Copy link
Contributor

@iamhsa iamhsa commented Oct 22, 2018

Hi,

Here a PR to have tfenv working with terraform alpha versions.
With the last terraform_0.12.0-alpha1 tfenv install latest is broken.

Best regards

@iamhsa iamhsa changed the title Deal with terrform alpha versions Deal with terraform alpha versions Oct 23, 2018
Copy link

@jmelowry jmelowry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

./tfenv install latest
[INFO] Installing Terraform v0.12.0-alpha2
[INFO] Downloading release tarball from https://releases.hashicorp.com/terraform/0.12.0-alpha2/terraform_0.12.0-alpha2_darwin_amd64.zip
######################################################################## 100.0%
[INFO] Downloading SHA hash file from https://releases.hashicorp.com/terraform/0.12.0-alpha2/terraform_0.12.0-alpha2_SHA256SUMS
tfenv: tfenv-install: [WARN] Unable to verify GPG signature unless logged into keybase and following hashicorp
Archive:  tfenv_download.bfmBnv/terraform_0.12.0-alpha2_darwin_amd64.zip
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-aws_v1.40.0-6-gb23683732_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-azurerm_v1.17.0-5-ga3b48ba3_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-google_v1.19.1-4-gf3de5334_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-null_v1.0.0-5-gf54ff98_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-template_v1.0.0-5-g317c9c9_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-random_v2.0.0-5-g612dff2_x4
 extracting: /Users/jamie_lowry/github/tfenv/versions/0.12.0-alpha2/terraform-provider-local_v1.1.0-5-ga2df742_x4
[INFO] Installation of terraform v0.12.0-alpha2 successful
[INFO] Switching to v0.12.0-alpha2
[INFO] Switching completed

@iamhsa
Copy link
Contributor Author

iamhsa commented Nov 14, 2018

Hi,
Does anyone know why this PR is blocked ?
As I understand, a reviewer with a write access, must accept it, but perhaps I have missed something.
Let me know.
Thanks

@nvtkaszpir
Copy link

Maybe extend it later to not install alpha/beta/rc as latest?
rc, could be as latest, but alpha is pretty edgy ;)

@iamhsa iamhsa mentioned this pull request Dec 6, 2018
@hmakkapati
Copy link

Bump :)
What seems to be blocking this PR?

@genevera
Copy link
Collaborator

genevera commented Feb 8, 2019

Squash the two commits and I'll merge.

@Zordrak Zordrak merged commit d8e36b0 into tfutils:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants