Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce minimal width to 360px for mobile support #45

Closed
1peter10 opened this issue Nov 18, 2023 · 1 comment · Fixed by #46
Closed

Reduce minimal width to 360px for mobile support #45

1peter10 opened this issue Nov 18, 2023 · 1 comment · Fixed by #46

Comments

@1peter10
Copy link

Hi,

I have just tried your great app on the Librem 5 and it's working quite well (when applying the scale-to-fit "hack" that makes too wide apps fit the screen in Phosh) on mobile already, and I am really glad to see more work regarding mobile support in #44 !

360px would be the correct value due to 2x scaling on a 1440x720px screen (or 3x on 1080px wide screens when held in portrait)

See https://developer.gnome.org/hig/guidelines/adaptive.html for reference.

(BTW, if you have input to make https://linuxphoneapps.org/docs/resources/developer-information/ better, please get in touch :) )

Here's how the app looks as is:

Without any tweaks

And here in it's current form with scale-to-fit

With scale-to-fit

Menu with scale-to-fit

I am happy to help with testing, unfortunately (day job) it may take me a bit to give proper feedback.

@tfuxu
Copy link
Owner

tfuxu commented Nov 18, 2023

I fixed this issue, now the window should properly scale to the recommended 360px.

The culprit here was an unused successful dithering report page, which for some reason made the whole window structure require an additional 100 pixels from the already set 360px.

Also, thanks for linking linuxphoneapps's docs, its a pretty useful resource!
PS. Please don't close this issue, I'll close it myself when I'll finish making the fix.

@tfuxu tfuxu added this to the Halftone 0.5.0 milestone Dec 3, 2023
@tfuxu tfuxu mentioned this issue Dec 3, 2023
@tfuxu tfuxu closed this as completed in #46 Dec 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants