Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to optionally list pre-release versions #22

Conversation

mmourick
Copy link
Collaborator

@mmourick mmourick commented Mar 7, 2024

What

  • Adds --pre-release option to list subcommand to display pre-release versions of Terraform
  • Changes list behavior by hiding pre-release versions by default.

Why

  • Declutters the list of Terraform versions listed, as pre-releases are not relevant for the majority of users.

References

@ChrisTerBeke
Copy link
Collaborator

There's a conflict with the main branch, did you rebase? All the color-coded output has been moved to helper functions :)

@mmourick mmourick force-pushed the feat/optionally-list-pre-release-versions branch from 83810ea to ce4a28a Compare March 7, 2024 16:59
@mmourick
Copy link
Collaborator Author

mmourick commented Mar 7, 2024

@ChrisTerBeke Yeah had to resolve a small merge conflict, I've updated the PR now to use the new helper functions 👍

Copy link
Collaborator

@ChrisTerBeke ChrisTerBeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

In addition to the two comments in the code, it would be great if the help text (listExample) could be updated to include this new flag, as well as the README.

cmd/list.go Outdated Show resolved Hide resolved
cmd/list.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 7, 2024
@ChrisTerBeke ChrisTerBeke merged commit e8b112b into tfversion:main Mar 7, 2024
4 checks passed
@mmourick mmourick deleted the feat/optionally-list-pre-release-versions branch March 7, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide pre-release versions from list unless indicated
3 participants