Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slice bounds out of range error for tfversion list #27

Merged
merged 1 commit into from Mar 7, 2024
Merged

Fix slice bounds out of range error for tfversion list #27

merged 1 commit into from Mar 7, 2024

Conversation

mmourick
Copy link
Collaborator

@mmourick mmourick commented Mar 7, 2024

What

  • Set the right iteration limit

Why

tfversion list would output:

panic: runtime error: slice bounds out of range [:309] with capacity 256

References

  • N/A

ChrisTerBeke
ChrisTerBeke approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ChrisTerBeke ChrisTerBeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! We need some automated tests :P

@ChrisTerBeke ChrisTerBeke merged commit 11758df into main Mar 7, 2024
5 checks passed
@ChrisTerBeke ChrisTerBeke deleted the fix/runtime-error-when-iterating-over-versions-slice branch March 7, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTerBeke ChrisTerBeke ChrisTerBeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmourick @ChrisTerBeke