Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with phoenix_html 4.0 #108

Closed
wants to merge 1 commit into from

Conversation

obieewan
Copy link

No description provided.

@tfwright
Copy link
Owner

Hi @obieewan bit confused here since I haven't seen any errors around this and phoenix_html has been locked to 4 for while now. Can you give a bit more context on the source of the problem this fixes?

@obieewan
Copy link
Author

obieewan commented Apr 1, 2024

Hello @tfwright , I encountered this error when I compile the app after adding this as dependency:
Screenshot 2024-04-01 at 10 30 47

This is my current setup:
Screenshot 2024-04-01 at 10 32 36

@eriknaslund
Copy link

eriknaslund commented Apr 2, 2024

I had the same issue, and I think I figured out why.

I added {:live_admin, "~> 0.11.4"} to my mix.exs, and I got the same error message ("use Phoenix.HTML is no longer supported in v4.0"). Looking through the code that got pulled I can indeed see lots of use Phoenix.HTML.

It seems like it was all fixed in this commit: 364653d
This commit is from Feb 3rd, which is after the release of 0.11.4 (Jan 29), so it's not included in the latest release.

I pulled the live_admin code from latest main here on Github and voila - everything works :)
All we need here is probably a new release to hex.pm.

@tfwright
Copy link
Owner

Released https://hex.pm/packages/live_admin/0.11.5

@tfwright tfwright closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants