Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image_url attribute and location quickreply #33

Merged
merged 5 commits into from
Feb 22, 2017
Merged

add image_url attribute and location quickreply #33

merged 5 commits into from
Feb 22, 2017

Conversation

guilebc
Copy link
Contributor

@guilebc guilebc commented Dec 6, 2016

I added and updated the quick replies:

  • Added the image_url attribute for quick text responses.
  • Added quick replies for locations.

@tgallice
Copy link
Owner

@guilebc Thanks for this ! Can you add the ability to retrieve the coordinates of a location quick reply ?

$this->shouldHaveType('Tgallice\FBMessenger\Model\QuickReply\Text');
}

function it_is_a_button()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it_is_a_quickreply


return $json;
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can you add an newline ? On others files too :)

@tgallice
Copy link
Owner

tgallice commented Feb 22, 2017

Hi @guilebc, thank a lot ! Just my 2 comments and I will merge !

@tgallice
Copy link
Owner

@guilebc awesome !

@tgallice tgallice merged commit 6cf9129 into tgallice:master Feb 22, 2017
Shaked pushed a commit to Shaked/fb-messenger-sdk that referenced this pull request Aug 24, 2017
* add image_url attribute and location quickreply

* quickreply:location: add getter lat/long

* Add Domain Whitelisting

* Clear code (tgallice#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants