out_ascii.c: 2 * possible reads of bad data ?

[dcb314]

out_ascii.c:62:6: warning: variable 'tx1prec' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
out_ascii.c:67:6: warning: variable 'tx2prec' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Suggest initialise local variable tx1prec and tx2prec at their declarations.

[tgraf]

Fixed in:

commit e0efec0
Author: Thomas Graf tgraf@suug.ch
Date: Tue May 6 15:01:53 2014 +0200

ascii: Initialize prec variables

Ensure that branching does not leave behind uninitialized variables

Reported-by: dcb314
Signed-off-by: Thomas Graf <tgraf@suug.ch>

diff --git a/src/out_ascii.c b/src/out_ascii.c
index 40a70e2..b3e8d2d 100644
--- a/src/out_ascii.c
+++ b/src/out_ascii.c
@@ -55,7 +55,7 @@ static void print_list(struct element *e)
{
char *rxu1 = "", *txu1 = "", *rxu2 = "", *txu2 = "";
double rx1 = 0.0f, tx1 = 0.0f, rx2 = 0.0f, tx2 = 0.0f;

•   int rx1prec, tx1prec, rx2prec, tx2prec;
  

•   int rx1prec = 0, tx1prec = 0, rx2prec = 0, tx2prec = 0;
  char pad[IFNAMSIZ + 32];
  struct attr *a;