Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players Duplicating in list and sometimes on map #33

Closed
JasonO99 opened this issue Mar 28, 2019 · 15 comments
Closed

Players Duplicating in list and sometimes on map #33

JasonO99 opened this issue Mar 28, 2019 · 15 comments

Comments

@JasonO99
Copy link

https://i.gyazo.com/dcb5bf8cb3bd3f69ca64538188cb6620.png
https://i.gyazo.com/609c241321dffc4a9792f2f150f4b386.png

The list of players is occasionally populating numerous times with the same player. Refreshing the page fixes this. Unable to do anything to reproduce at the moment. Just load the page and after some time (anything from a minute to 15 minutes) I will notice this. The player count also appears incorrect at times to what it actually is (eg in image 2 it shows 3 players, when in fact there is only two - confirmed by looking at players.json on the FiveM server).

Also, sometimes when this happens the marker duplicates (with one being frozen, while the other is moving with the player). It doesn't happen all the time. Also, some players no longer on the server remain on the map.
https://i.gyazo.com/d171ec53a45f9f16137eeb2a3f53fba1.png

I'm running the latest version of Chrome and on Windows 10. Let me know if there's anything else I can offer/look at to help you figure out the issue?

TGRHavoc added a commit that referenced this issue Apr 16, 2019
This should reset the UI elements such as the player list when switching servers.
Before, it wouldn't reset showing you the players for the previous server you were viewing.

Not sure if this is related to #33.
@TGRHavoc
Copy link
Owner

TGRHavoc commented Apr 16, 2019

@JasonO99 Mind testing 9ea1655 for me?

Just download the develop branch.

@JasonO99
Copy link
Author

Uploaded. Will test tonight.

@JasonO99
Copy link
Author

JasonO99 commented Apr 18, 2019

@TGRHavoc
http://kentroleplay.co.uk/map2/
Still getting the issue of duplication. Just remain on the page and wait a while. This will only really be busy 1930 - 2130.

https://i.gyazo.com/a3639e98f2dbc222380b79b5dbeadd6b.png

@TGRHavoc
Copy link
Owner

TGRHavoc commented Apr 18, 2019

Hmm. I'm not able to reproduce the errors you're having, The only thing that I can think of is that somehow the player's identifiers are changing from the values originally sent to the map somehow. And that just seems like something that shouldn't happen (I'm basically grasping at straws to try and come up with an idea as to why it's breaking).

The only thing I can do is ask for some more data to try and pinpoint the issue.
VPS OS - some people have reported the resource not working properly on Linux. May be causing some issues here too, maybe I'm not keeping the interface open long enough to see the server somehow changing stuff it sends.
Browser - It could be a browser issue. Somehow

Ok. So, whilst writing this reply, I've manage to capture the issue you're having... By the looks of it, the server is picking up that the player is on it but, not sending the identifier of the server. Since the interface relies on that being set in the player options (and in a cache, used for creating markers) it could be causing issues.

The latest commit on develop branch f735376 should actually fix this.

You're not by any chase using OneSync are you?

@JasonO99
Copy link
Author

Not using OneSync. Linux server using the latest build (on Zap Hosting).

@JasonO99
Copy link
Author

I've updated the code on that last commit. Will look to check this when we have our next burst of players (1930 UK time).

@JasonO99
Copy link
Author

Unfortunately, the issue is still occurring.

https://i.gyazo.com/3cb7816c8d4f6fff179c76a4b05e9f66.png

@TGRHavoc
Copy link
Owner

Unfortunately, the issue is still occurring.

https://i.gyazo.com/3cb7816c8d4f6fff179c76a4b05e9f66.png

You did download the dist/ folder, right? That's what contains the JS for the main page. Otherwise, only the debug.html file will have the changes (I say this because I can't find the added line in first-bundle.js).

@JasonO99
Copy link
Author

I thought I did. I've downloaded it again, deleted all files except images and reuploaded. Config redone. Will test again in 17 hours time.

@JasonO99
Copy link
Author

I've uploaded the development branch completely. Still doing it.

http://kentroleplay.co.uk/map2/

@TGRHavoc
Copy link
Owner

I'm a fucking moron. Should work as 5cf8513

@JasonO99
Copy link
Author

Is that the only file change?

@TGRHavoc
Copy link
Owner

Yea.

@JasonO99
Copy link
Author

Uploaded. Will update you again.

@JasonO99
Copy link
Author

Been on 30 minutes. The issue would have certainly appeared by now but has not done so; so appears issue is fixed.

TGRHavoc added a commit that referenced this issue May 17, 2019
This should reset the UI elements such as the player list when switching servers.
Before, it wouldn't reset showing you the players for the previous server you were viewing.

Not sure if this is related to #33.
TGRHavoc added a commit that referenced this issue May 17, 2019
This should actually fix #33

closes #33
TGRHavoc added a commit that referenced this issue Jul 28, 2021
This should reset the UI elements such as the player list when switching servers.
Before, it wouldn't reset showing you the players for the previous server you were viewing.

Not sure if this is related to #33.
TGRHavoc added a commit that referenced this issue Jul 28, 2021
This should actually fix #33

closes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants