fixes bug when using dot in as identifier

[a0viedo]

I've encountered what I think is a bug on the formatting of SQL statements. Take the following example:

var knex = require('knex')(config);
console.log(knex.select('id as foo.bar').from('users').toSQL());

This would print

{ method: 'select',
  options: {},
  bindings: [],
  sql: 'select "id" as "foo"."bar" from "users"' }

like trying to access a field in the alias but instead should be formatted as

{ method: 'select',
  options: {},
  bindings: [],
  sql: 'select "id" as "foo.bar" from "users"' }

[elhigu]

As far as I know, the correct format is "foo"."bar". @a0viedo why do you think it is wrong?

EDIT: Looks like you are right... since it is single identifier after as it is not table/column reference, the correct quoting really seem to be as you suggest.

[elhigu]

Looks like test error was just a timeout, I retriggered the build.

[elhigu]

@a0viedo good catch and thanks for the fix!

[a0viedo]

@elhigu thank you!