Several bugs with MS SQL schema creation #1577
Comments
statyan
added a commit
to statyan/knex
that referenced
this issue
Jul 13, 2016
Aslo corrected tests for primarykey
rhys-vdw
pushed a commit
that referenced
this issue
Jul 20, 2016
smorey2
pushed a commit
that referenced
this issue
Nov 26, 2016
…mber with decimal part conversion (#1707) * Fixed knex #1577 Aslo corrected tests for primarykey * Fix for installing from github * Fix for installing from github * Fix for installing from github * Move LOCK hint for MSSQL after join component of select * Add missing import statement * Added "WITH" clause to select, update, insert and delete queries. Fixed forUpdate lock query building Add detection of decimal value of Numeric parameter and set proper sql.Type for it. (Fix for #1604) * Change let to const for variable declaration * Fix MSSQL non-numeric parameters binding
elhigu
pushed a commit
to elhigu/knex
that referenced
this issue
Feb 15, 2017
…mber with decimal part conversion (knex#1707) * Fixed knex knex#1577 Aslo corrected tests for primarykey * Fix for installing from github * Fix for installing from github * Fix for installing from github * Move LOCK hint for MSSQL after join component of select * Add missing import statement * Added "WITH" clause to select, update, insert and delete queries. Fixed forUpdate lock query building Add detection of decimal value of Numeric parameter and set proper sql.Type for it. (Fix for knex#1604) * Change let to const for variable declaration * Fix MSSQL non-numeric parameters binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an issue with float type column is MSSQL columncompiler. It generates code
ADD COLUMN ColName float(8,2), but MSSQL accepts onlyfloat(x), where x is size for bits holding mantissa.MSSQL also have no double type column, float and double from knex should compile to
decimal(x,y)column type.Column type
bitis always exactly one bit, so call it withtable.column('a').bit(x)', where x is any number, leads to error.Also, the
firstandaftermodifiers are not available for MSSQL.So, I've fixed this issues and create current Issue just to connect it to the pull request.
The text was updated successfully, but these errors were encountered: