Transaction should not reject with undefined. #1970
Conversation
| this._resolver(value) | ||
| } | ||
| if (status === 2) { | ||
| if(isUndefined(value)) { |
There was a problem hiding this comment.
Is the intention to only do this when rejecting with undefined? I'm not sure under what circumstances this issue could occur (as I haven't followed the issue closely), but other non-Error rejection values such as numbers or strings would have the same "missing stacktrace" issue.
There was a problem hiding this comment.
Yes, this is intentional. By definition undefined is the only javascript type that can be considered non-existant. Null, Strings, Numbers, Objects, Errors, Buffers, or any other type of value is still valid.
For example some people prefer to use strings (why is beyond me):
try {
throw 'poop'
} catch(e) {
console.log(e, typeof e);
//poop string
}So in cases where rollback is called with an explicit value other than undefined, that value will be used in the reject handler.
* Fixed transaction promise to not be overridden * Disabled failing test case until #1970 feature if fixed.
No description provided.