Support node-mssql 4.0.0 #2029
Merged
Support node-mssql 4.0.0 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compatible with 3.3.0 & 4.0.1 knex#1999
eslint src/** src/dialects/mssql/index.js 77:1 error Line 77 exceeds the maximum line length of 100 max-len
|
It would be better to just update the node-mssql from package.json and support only node-mssql >4. Now one of the code paths gets never tested. |
|
Are there any plans for merging this soon, possibly for a 0.13.1 change? This is blocking me from upgrading mssql, and I'd help in any way necessary (big knex.js fan!) |
elhigu
requested changes
May 20, 2017
elhigu
approved these changes
May 21, 2017
|
Thanks! |
|
Is this ever going to make it to the version deployed in npm? |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only support node-mssql@^4.0.0
Try to fix #1999