Fix comments not being applied to increments columns #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t lookup map on the generic columncompiler
|
/home/travis/build/tgriesser/knex/src/schema/columncompiler.js 100 sounds really small limit though, it could be increased to at least 140 or like that. |
elhigu
approved these changes
Sep 27, 2017
|
|
This looks great now, thanks! |
elhigu
pushed a commit
to ivanfilhoz/knex
that referenced
this pull request
Oct 16, 2017
* Removed check increments check on the modifiers. Implemented a default lookup map on the generic columncompiler * Ignore VS Code User Workspace Settings * Added test case to assert comments are added to increments columns * Shortened line length and added explicit db tests for postgres and mysql dialects * Added check for modifiers on incrementing types and only allow comment modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2210
Changes
I first had to remove the explicit check in the
getModifiersfunction that excluded auto-increment columns.I then abstracted the default column name logic for increments columns to a separate function on the prototype of the generic column compiler. I did this because if a user specified a comment on an increments column with no explicit name, the dialect level
commentmethod could not figure out the default column name. It is implemented with a lookup map fordefaults. In the future, if new defaults are added, developers can add a new default key.Finally, I added a specific assertion in a test case to ensure comments are applied to increments columns in the future
Notes
.vscode/exclusion to the.gitignore. Visual Studio Code allows developers to set up settings on a workspace basis.