Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate:down functionality #3228

Merged
merged 11 commits into from
May 29, 2019

Conversation

leeallen337
Copy link
Contributor

This pull request attemps to add a new feature requested in #666 and briefly in #352

The feature is adding a migrate:down functionality which would rollback only the last run migration to the Migrator API and the CLI

Documentation PR: knex/documentation#197

@leeallen337 leeallen337 marked this pull request as ready for review May 29, 2019 01:28
@kibertoad
Copy link
Collaborator

kibertoad commented May 29, 2019

Thanks!

@kibertoad kibertoad merged commit 1fe5ee0 into knex:master May 29, 2019
@kibertoad
Copy link
Collaborator

@leeallen337 Do you use Node 8+? Next major release 0.18 is going to drop Node 6 support, so if you need it on an older node, would make sense to merge this PR to branch 0.17.

@leeallen337
Copy link
Contributor Author

@kibertoad I do use Node 8+. Maybe it should get merged into 0.17? I saw that migrate:up made it into 0.16 so it might be beneficial for users still on Node 6 to have migrate:down in addition to migrate:up?

I went ahead and created a pull request for it since I'm about to leave for work and won't be available until later

#3232

@leeallen337 leeallen337 deleted the feature/add-down-for-migrations branch June 5, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants