fix: make transaction rejection consistent across dialects #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Aug 16, 2019
| sql.toUpperCase() === 'ROLLBACK' && | ||
| t.doNotRejectOnRollback | ||
| ) { | ||
| if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) { |
There was a problem hiding this comment.
What happens if sql is nil here? It just resolves to false or throw an error?
|
You can pull latest changes from master to resolve oracle test failures. |
thetutlage
force-pushed
the
fix/transactions
branch
from
f3e6616
to
181402c
Compare
kibertoad
approved these changes
Aug 17, 2019
|
Thanks! I'll try to publish new release tonight. |
|
Wow, thanks 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
mysqlandmysql2dialects use the samesqlcheck as the base transaction class.