Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction isolation support #4185

Merged
merged 29 commits into from
Dec 30, 2020
Merged

Add transaction isolation support #4185

merged 29 commits into from
Dec 30, 2020

Conversation

ayroblu
Copy link
Contributor

@ayroblu ayroblu commented Dec 29, 2020

Attempt to solve #581
Probably needs some extra tests, not sure where the best place to put them is.
Also probably needs to implement for all drivers rather than just half of them

Syntax is knex.transaction(...).setIsolationLevel('string')

types/index.d.ts Outdated Show resolved Hide resolved
test/unit/knex.js Outdated Show resolved Hide resolved
@ayroblu
Copy link
Contributor Author

ayroblu commented Dec 29, 2020

Urg I don't get why it's still failing, it passes fine locally :/
image
And I get unrelated failures when I run the whole thing
image

@kibertoad
Copy link
Collaborator

@clemens-smartparking Unfortunately, that is not that straightforward. First of all, Objection TS types need to be adjusted, as seen in Vincit/objection.js#1992. Second, looks like Objection is importing some of knex internal files directly, so that will need to be adjusted as well. I'll spend some time this week to fix incompatibilities on Objection side, hopefully some kind of next release can be done for Objection as well.

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants