Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): table builder some methods return wrong types #4764

Merged
merged 1 commit into from Oct 23, 2021
Merged

fix(typings): table builder some methods return wrong types #4764

merged 1 commit into from Oct 23, 2021

Conversation

maximelkin
Copy link
Collaborator

@maximelkin maximelkin commented Oct 22, 2021 •
edited

@kibertoad kibertoad merged commit 58de7a9 into knex:master Oct 23, 2021
OlivierCavadenti pushed a commit to AbeonaPascha/knex that referenced this pull request Nov 4, 2021
@maximelkin @OlivierCavadenti
fix(typings): table builder some methods return wrong types (knex#4764)
785ed3e 
Co-authored-by: maximelkin <maxeljkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript Definition: Renaming column name returns ColumnBuilder, but actually it's not.
2 participants
@maximelkin @kibertoad