Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonb type to schema. #1044

Merged
merged 2 commits into from
Nov 11, 2015
Merged

Jsonb type to schema. #1044

merged 2 commits into from
Nov 11, 2015

Conversation

elhigu
Copy link
Member

@elhigu elhigu commented Nov 4, 2015

Fix for issue #991

@elhigu
Copy link
Member Author

elhigu commented Nov 5, 2015

@rhys-vdw / @tgriesser any comments to this?

@rhys-vdw
Copy link
Member

rhys-vdw commented Nov 5, 2015

Hey @elhigu. Could you please remove references to the jsonb bool argument to schema.json() documentation, and add a deprecation message if it is supplied?

@rhys-vdw
Copy link
Member

rhys-vdw commented Nov 5, 2015

Otherwise looks great.

@elhigu
Copy link
Member Author

elhigu commented Nov 6, 2015

Great, I'll fix / update pull request tomorrow.

@elhigu
Copy link
Member Author

elhigu commented Nov 7, 2015

Aand now this is fixed, no more documentation about json(true) and added deprecation message.. I also added sent fixes for #662 and #1003

@elhigu
Copy link
Member Author

elhigu commented Nov 11, 2015

@rhys-vdw I updated this pull request few days ago with suggested changes... would it be ok now to be merged?

@rhys-vdw
Copy link
Member

Hey @elhigu, just hadn't gotten around to the review. Looks good.

rhys-vdw added a commit that referenced this pull request Nov 11, 2015
@rhys-vdw rhys-vdw merged commit 3a8a6e8 into knex:master Nov 11, 2015
@elhigu elhigu deleted the added-jsonbcolumn-type branch January 21, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants