Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute tests on Node 12 #3171

Merged
merged 12 commits into from May 11, 2019

Conversation

Projects
None yet
2 participants
@kibertoad
Copy link
Collaborator

commented Apr 28, 2019

No description provided.

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 28, 2019

Currently blocked by sqlite support: mapbox/node-sqlite3#1151

@DRoet

This comment has been minimized.

Copy link

commented May 10, 2019

FYI the upstream issue has been fixed in sqlite 4.0.7

kibertoad added some commits May 10, 2019

@kibertoad kibertoad requested a review from elhigu May 10, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented May 10, 2019

@elhigu Do you prefer to wait with merging this one until Docker tests one lands since this one would be easier to resolve conflicts for?

@@ -60,13 +60,13 @@ services:
addons:
postgresql: '9.6'
apt:
sources:
- mysql-5.7-trusty

This comment has been minimized.

Copy link
@kibertoad

kibertoad May 10, 2019

Author Collaborator

MySQL 5.7 is default on Xenial, no explicit sources are needed.

.travis.yml Outdated
packages:
- g++-4.8
- gcc-4.8
- g++-5

This comment has been minimized.

Copy link
@kibertoad

kibertoad May 10, 2019

Author Collaborator

new SQLite version requires gcc 5

@kibertoad

This comment has been minimized.

Copy link
Collaborator Author

commented May 11, 2019

End changes are not that intrusive (since xenial actually has needed gcc deps by default), so conflict resolution should be in either case quite trivial.

@kibertoad kibertoad merged commit 542ece6 into master May 11, 2019

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 85.231%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kibertoad kibertoad deleted the chore/node-12 branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.