Execute tests on Node 12 #3171
Merged
Execute tests on Node 12 #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently blocked by sqlite support: TryGhost/node-sqlite3#1151 |
|
FYI the upstream issue has been fixed in sqlite |
|
@elhigu Do you prefer to wait with merging this one until Docker tests one lands since this one would be easier to resolve conflicts for? |
kibertoad
commented
May 10, 2019
| @@ -60,13 +60,13 @@ services: | |||
| addons: | |||
| postgresql: '9.6' | |||
| apt: | |||
| sources: | |||
| - mysql-5.7-trusty | |||
There was a problem hiding this comment.
MySQL 5.7 is default on Xenial, no explicit sources are needed.
kibertoad
commented
May 10, 2019
.travis.yml
Outdated
| packages: | ||
| - g++-4.8 | ||
| - gcc-4.8 | ||
| - g++-5 |
There was a problem hiding this comment.
new SQLite version requires gcc 5
|
End changes are not that intrusive (since xenial actually has needed gcc deps by default), so conflict resolution should be in either case quite trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.