Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to resolve knexfile.ts when knexfile.js does not exist #3272

Merged
merged 5 commits into from
Jun 10, 2019

Conversation

kibertoad
Copy link
Collaborator

fixes #3003

@kibertoad kibertoad requested a review from elhigu June 8, 2019 23:09
@kibertoad kibertoad changed the base branch from master to 0.17 June 8, 2019 23:09
@kibertoad
Copy link
Collaborator Author

@eioo @dgadelha Please take a look if it addressed the problem that you are having.

@dgadelha
Copy link

dgadelha commented Jun 9, 2019

It parses knexfile.ts, but generated migrations are generated as js files, which is a different behavior from what was at 0.15 (it generated ts migration files if your knexfile was ts)

Also, thanks for the quick fix

@kibertoad
Copy link
Collaborator Author

Hmmm, interesting. Why not just pass extension that you want though? I'll see what I can do to get old behavior back.

@dgadelha
Copy link

It's just to keep the standards for a project, if you're using a TypeScript knexfile, you'll probably want TypeScript migrations too, plus restores the behavior that 0.16 broke.

@kibertoad
Copy link
Collaborator Author

@dgadelha That's a separate low-impact issue, though, that is easily solved with minimum amount of changes from the user side. Since that would require reshuffling code around quite a bit, I'll address it in a separate PR.

@kibertoad kibertoad merged commit f3e991d into 0.17 Jun 10, 2019
@kibertoad kibertoad deleted the fix/3003-migrate-make branch December 27, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants