Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding four boards to the list of R&D circuit designs #3231

Merged
merged 3 commits into from
Mar 31, 2014
Merged

Adding four boards to the list of R&D circuit designs #3231

merged 3 commits into from
Mar 31, 2014

Conversation

phil235
Copy link
Contributor

@phil235 phil235 commented Mar 29, 2014

Adds the boards for telecom traffic control console, telescience console, mechbay recharger and vendor to the list of R&D designs.
Fixes some minor typos.
Fixes #3103

pull from tgstation master to phil235 master
Adds the boards for telecom traffic control console, telescience console, mechbay recharger and vendor to the list of R&D designs.
Fixes some minor typos.
@Razharas
Copy link
Contributor

Nice

@@ -363,6 +363,24 @@ datum/design/message_monitor
materials = list("$glass" = 2000, "sacid" = 20)
build_path = /obj/item/weapon/circuitboard/message_monitor

datum/design/comm_traffic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck no.

@phil235
Copy link
Contributor Author

phil235 commented Mar 29, 2014

Heck no.

What's the problem with that line?

@vista-
Copy link
Contributor

vista- commented Mar 29, 2014

The problem is with the board itself.

@Razharas
Copy link
Contributor

And the problem is?

@phil235
Copy link
Contributor Author

phil235 commented Mar 29, 2014

The problem is with the board itself.

The design list already includes the 3 other Telecoms consoles boards. Is this one really that different?

@Kraseo

This comment was marked as abuse.

@vista-
Copy link
Contributor

vista- commented Mar 29, 2014

Yes, this gives people the ability to fuck with communications pretty easily. Also multiple people can't edit Tcomm scripts at the same time, so a guy can just stand by the console for the entire round and no-one will be able to remove the script.

@phil235
Copy link
Contributor Author

phil235 commented Mar 29, 2014

It needs to be within 25 tiles of the station's Telecom servers though, so this limits the possibilities. And without the ability to build the board, the station cannot replace its unique traffic console if it is destroyed.

@vista-
Copy link
Contributor

vista- commented Mar 29, 2014

Oh, then it's fine.

req_tech = list("programming" = 1)
build_type = IMPRINTER
materials = list("$glass" = 2000, "sacid" = 20)
build_path = /obj/item/weapon/circuitboard/vendor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuuuuuuuuh

@phil235
Copy link
Contributor Author

phil235 commented Mar 29, 2014

@Anonus Is there an issue with that part of the code?

@optimumtact
Copy link
Member

@Anonus they might be flagged due to the line endings changing

A problem which will go away once all files have been converted.

fleure pushed a commit that referenced this pull request Mar 31, 2014
Adding four boards to the list of R&D circuit designs
@fleure fleure merged commit d38a85b into tgstation:master Mar 31, 2014
Addust pushed a commit to Addust/tgstation that referenced this pull request Sep 11, 2024
* tested

* better objective names, delta time stuff, etc
Addust pushed a commit to Addust/tgstation that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telescience console missing from RnD boards list.
7 participants