Port tg statpanel #13546

vvvv-vvvv · 2023-07-21T19:13:26Z

About The Pull Request

Port tg statpanel

Changelog

🆑
add: ported tg statpanel
/:cl:

ivanmixo

Not a fan of the "modern" stat panel personally but it is better code.

code/datums/components/connect_mob_behalf.dm

code/modules/admin/admin_verbs.dm

lbnesquik · 2023-07-25T11:01:12Z

Can we get a look at it? What's so good about it? I don't play TG

Barnet2 · 2023-07-26T17:55:27Z

Admin requests of a split of the admin tab back into admin and fun, alongside moving tickets

vvvv-vvvv · 2023-07-26T17:58:46Z

Admin requests of a split of the admin tab back into admin and fun, alongside moving tickets

It's a pref, but I'll change it to the older style by default

Barnet2 · 2023-07-26T18:19:17Z

Admin requests of a split of the admin tab back into admin and fun, alongside moving tickets

It's a pref, but I'll change it to the older style by default

Would you mind moving the tickets back over? Also, a bolding bug

ivanmixo · 2023-07-26T18:25:32Z

Mentors can see the MC tab apparently

ivanmixo · 2023-07-26T19:04:03Z

Also game panel is missing

GravitronBlue · 2023-08-09T17:23:24Z

Alt-click menu items can't be middle clicked with xeno abilities, which prevents being able to melt large stacks of items/flares on a single tile; same goes for trying to melt airlocks under blast doors.
Litterally fine now, but I swear it was broken earlier, guh.

Lumipharon · 2023-08-11T05:13:01Z

code/modules/mob/dead/observer/observer.dm

+	if(SSticker.mode)
+		var/rulerless_countdown = SSticker.mode.get_hivemind_collapse_countdown()
+		if(rulerless_countdown)
+			. += "Orphan hivemind collapse timer: [rulerless_countdown]"
+	if(GLOB.respawn_allowed)
+		status_value = (GLOB.key_to_time_of_role_death[key] + SSticker.mode?.respawn_time - world.time) * 0.1
+		if(status_value <= 0)
+			. += "Respawn timer: READY"
+		else
+			. += "Respawn timer: [(status_value / 60) % 60]:[add_leading(num2text(status_value % 60), 2, "0")]"
+		if(SSticker.mode?.flags_round_type & MODE_INFESTATION)
+			if(larva_position)
+				. += "Position in larva candidate queue: [larva_position]"
+			var/datum/job/xeno_job = SSjob.GetJobType(/datum/job/xenomorph)
+			var/stored_larva = xeno_job.total_positions - xeno_job.current_positions
+			if(stored_larva)
+				. += "Burrowed larva: [stored_larva]"
+	//game end timer for patrol and sensor capture
+	var/patrol_end_countdown = SSticker.mode?.game_end_countdown()
+	if(patrol_end_countdown)
+		. += "Round End timer: [patrol_end_countdown]"
+	//respawn wave timer
+	var/patrol_wave_countdown = SSticker.mode?.wave_countdown()
+	if(patrol_wave_countdown)
+		. += "Respawn wave timer: [patrol_wave_countdown]"
+	var/datum/game_mode/combat_patrol/sensor_capture/sensor_mode = SSticker.mode
+	if(issensorcapturegamemode(SSticker.mode))
+		. += "Activated Sensor Towers: [sensor_mode.sensors_activated]"


A lot of this stuff in get_status_tab_items() should all probably be in a game mode proc now that we are free from Stat().

are you sure a bunch of istypes in a gamemode proc will be cleaner than this

make it a gamemode proc so there is no istypes?

lbnesquik · 2023-08-12T20:09:28Z

Lumipharon · 2023-08-12T23:07:33Z

It would be good to fix this but uh, the current system is broken as fuck already, and just displays random icons half the time, of other items on that turf.

Lumipharon · 2023-08-14T12:03:59Z

code/modules/mob/living/carbon/human/human.dm

+	var/datum/game_mode/combat_patrol/sensor_capture/sensor_mode = SSticker.mode
+	if(issensorcapturegamemode(SSticker.mode))
+		. += "Activated Sensor Towers: [sensor_mode.sensors_activated]"


you did it for observers but not living mobs?

lbnesquik · 2023-08-14T17:28:07Z

It would be good to fix this but uh, the current system is broken as fuck already, and just displays random icons half the time, of other items on that turf.

This breaks the silicon tab tho, this one isn't broken currently.

Lumipharon

also what is actually with the image issue? Because yeah its not ideal, I'd rather not merge something that is clearly broken.

Lumipharon · 2023-08-14T21:58:33Z

code/datums/gamemodes/_game_mode.dm

+	var/patrol_end_countdown = game_end_countdown()
+	if(patrol_end_countdown)
+		items += "Round End timer: [patrol_end_countdown]"
+	var/patrol_wave_countdown = wave_countdown()
+	if(patrol_wave_countdown)
+		items += "Respawn wave timer: [patrol_wave_countdown]"


this should be in the combat patrol child proc.

but it's a var on gamemode

I guess its fine for now since the wording is generic.

But the countdowns are procs not vars. While the procs exist in the base gamemode, they don't do anything (but could be used in other gamemodes in the future of course) so this part of the stat should be where its actually used. i.e. combat patrol gamemode. But yeah, fine for now.

vvvv-vvvv · 2023-08-15T00:18:32Z

also what is actually with the image issue? Because yeah its not ideal, I'd rather not merge something that is clearly broken.

i think its something related to byond not sending the images in time, its supposed to retry when that happens but it doesnt work at all. broken upstream too i think

tgstation-server added Feature New interesting mechanics with new interesting bugs UI We make things worse, but rounder labels Jul 21, 2023

ivanmixo requested changes Jul 21, 2023

View reviewed changes

code/datums/components/connect_mob_behalf.dm Show resolved Hide resolved

code/modules/admin/admin_verbs.dm Show resolved Hide resolved

vvvv-vvvv force-pushed the tg-statpanel-port branch 4 times, most recently from 817eb31 to 661dedc Compare July 21, 2023 21:34

Port tg statpanel

f394368

vvvv-vvvv force-pushed the tg-statpanel-port branch from 661dedc to f394368 Compare July 22, 2023 02:21

TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jul 25, 2023

github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Jul 25, 2023

Merge remote-tracking branch 'upstream/master' into tg-statpanel-port

4c22fb3

tgstation-server removed Merge Conflict Pull request is in a conflicted state with base branch. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. labels Jul 25, 2023

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jul 25, 2023

comfyorange added a commit that referenced this pull request Jul 26, 2023

TGS Test Merge (#13546)

6a604a4

comfyorange added a commit that referenced this pull request Jul 26, 2023

TGS Test Merge (#13546)

fd3a6d3

comfyorange added a commit that referenced this pull request Jul 26, 2023

TGS Test Merge (#13546)

b5e977f

Remove HTML from status items

347b3e1

Fix order for tickets tab

f060b09

tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jul 26, 2023

vvvv-vvvv added 2 commits July 26, 2023 19:50

Fix MC tab showing for mentors

1dd0dd4

Fix admin tabs splitting by default

c67e71b

vvvv-vvvv force-pushed the tg-statpanel-port branch from b5791b3 to c67e71b Compare July 26, 2023 18:51

comfyorange added a commit that referenced this pull request Aug 9, 2023

TGS Test Merge (#13546)

4a87642

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Aug 9, 2023

comfyorange added a commit that referenced this pull request Aug 9, 2023

TGS Test Merge (#13546)

64b83d5

comfyorange added a commit that referenced this pull request Aug 9, 2023

TGS Test Merge (#13546)

e4a7f54

comfyorange added a commit that referenced this pull request Aug 9, 2023

TGS Test Merge (#13546)

a1f313c

Lumipharon requested changes Aug 11, 2023

View reviewed changes

comfyorange added a commit that referenced this pull request Aug 11, 2023

TGS Test Merge (#13546)

ce9c988

comfyorange added a commit that referenced this pull request Aug 12, 2023

TGS Test Merge (#13546)

66ab456

comfyorange added a commit that referenced this pull request Aug 12, 2023

TGS Test Merge (#13546)

1db20e5

comfyorange added a commit that referenced this pull request Aug 12, 2023

TGS Test Merge (#13546)

2da43cc

comfyorange added a commit that referenced this pull request Aug 12, 2023

TGS Test Merge (#13546)

a5e6c61

comfyorange added a commit that referenced this pull request Aug 12, 2023

TGS Test Merge (#13546)

0a84104

Add get_status_tab_items proc to gamemode

1d5bc8c

tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Aug 13, 2023

comfyorange added a commit that referenced this pull request Aug 13, 2023

TGS Test Merge (#13546)

f87f2c3

Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Aug 13, 2023

Lumipharon reviewed Aug 14, 2023

View reviewed changes

fix

7b62f76

tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Aug 14, 2023

Lumipharon requested changes Aug 14, 2023

View reviewed changes

Lumipharon approved these changes Aug 15, 2023

View reviewed changes

Lumipharon merged commit ccbd2d8 into tgstation:master Aug 15, 2023
6 checks passed

github-actions bot added a commit that referenced this pull request Aug 15, 2023

Automatic changelog for PR #13546 [ci skip]

89a742f

lKiseki mentioned this pull request Oct 15, 2023

Fixes View Variables not opening via HrefToken #14182

Merged

lbnesquik mentioned this pull request Oct 17, 2023

TG stat panel has horrible alt tile click performance #14209

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port tg statpanel #13546

Port tg statpanel #13546

vvvv-vvvv commented Jul 21, 2023

ivanmixo left a comment

lbnesquik commented Jul 25, 2023

Barnet2 commented Jul 26, 2023

vvvv-vvvv commented Jul 26, 2023

Barnet2 commented Jul 26, 2023

ivanmixo commented Jul 26, 2023

ivanmixo commented Jul 26, 2023

GravitronBlue commented Aug 9, 2023 •

edited

Loading

Lumipharon Aug 11, 2023

vvvv-vvvv Aug 12, 2023

Lumipharon Aug 12, 2023

lbnesquik commented Aug 12, 2023

Lumipharon commented Aug 12, 2023

Lumipharon Aug 14, 2023

lbnesquik commented Aug 14, 2023

Lumipharon left a comment

Lumipharon Aug 14, 2023

vvvv-vvvv Aug 15, 2023

Lumipharon Aug 15, 2023

vvvv-vvvv commented Aug 15, 2023

Port tg statpanel #13546

Port tg statpanel #13546

Conversation

vvvv-vvvv commented Jul 21, 2023

About The Pull Request

Changelog

ivanmixo left a comment

Choose a reason for hiding this comment

lbnesquik commented Jul 25, 2023

Barnet2 commented Jul 26, 2023

vvvv-vvvv commented Jul 26, 2023

Barnet2 commented Jul 26, 2023

ivanmixo commented Jul 26, 2023

ivanmixo commented Jul 26, 2023

GravitronBlue commented Aug 9, 2023 • edited Loading

Lumipharon Aug 11, 2023

Choose a reason for hiding this comment

vvvv-vvvv Aug 12, 2023

Choose a reason for hiding this comment

Lumipharon Aug 12, 2023

Choose a reason for hiding this comment

lbnesquik commented Aug 12, 2023

Lumipharon commented Aug 12, 2023

Lumipharon Aug 14, 2023

Choose a reason for hiding this comment

lbnesquik commented Aug 14, 2023

Lumipharon left a comment

Choose a reason for hiding this comment

Lumipharon Aug 14, 2023

Choose a reason for hiding this comment

vvvv-vvvv Aug 15, 2023

Choose a reason for hiding this comment

Lumipharon Aug 15, 2023

Choose a reason for hiding this comment

vvvv-vvvv commented Aug 15, 2023

GravitronBlue commented Aug 9, 2023 •

edited

Loading