Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGUI update #11451

Merged
merged 69 commits into from
Nov 12, 2022
Merged

TGUI update #11451

merged 69 commits into from
Nov 12, 2022

Conversation

SplinterGP
Copy link
Member

@SplinterGP SplinterGP commented Nov 4, 2022

About The Pull Request

yep, added more stuff, seeing if i can fix things and make it work woo.

Why It's Good For The Game

Changelog

🆑
fix: TGUI alerts now display buttons in a column when there's more than 2 options.
fix: TGUI alerts can now be disabled via turning TGUI inputs off in prefs.
fix: Fixed some bluescreens related to TGUI inputs.
fix: Fixes a runtime with material containers.
fix: TGUI now alerts the user when it is waiting on a refresh cooldown. In many cases, this will prevent screens from breaking that rely on static data.
fix: TGUI static data loading screens no longer resize the window temporarily. Note: If you are using a UI that gets a lot of these, please make an issue report.
fix: native fast gui boxes work again
fix: TGUI and Tooltip windows now work with high-dpi web browsers (People who are using Chromium through black magick or who have manually enabled DPI scaling for IWebBrowser2, or its already native due to byond updates ? idk)
qol: The reconnect button in tgchat will now reopen the game.
refactor: Ping system of tgui-panel has been reworked, which fixes things mentioned below.
fix: AFK players now get properly detected and kicked
fix: Automatic reconnect should now work 100% of the time
fix: Manual reconnect should now work 100% of the time
add: The accounting console has been added to the HOP's office, allowing them to track purchases, and bank balances of the crew on station. It's not illegal, it's the competitive advantage!
fix: renamed suffix for tgui-polyfill from bundle.js to min.js to prevent CBT failing after target 'clean'
code: Prettier is now recommended as an extension for UI development (or just in general!)
refactor: Many, many interfaces have been hit with the prettier stick so please report any issues. There should be zero noticeable differences in how UIs look or function.
add: Examining and other chat outputs now display in blocks to make them easier to see
fix: AI and borgs no longer have their name show twice upon being examined
fix: Fixed "Script Error" in tgui and tgchat (hopefully).
fix: Multiline inputs can now finally support line breaks, accessible via shift-enter! A maximum of two consecutive line breaks is allowed, any more than that will be automatically stripped. This only applies to input boxes that start with the multiline view enabled, and will thus not work on input boxes that aren't meant to support it.
code: restrictedinput can now accept negative numbers
qol: the full window refresh time is now one second instead of five seconds
fix: refreshing windows ("please wait...") no longer hang for up to twice as long as they should
/:cl:

@TiviPlus
Copy link
Member

TiviPlus commented Nov 7, 2022

Ran all test suites.
=> Finished 'tgui-test' in 11.459s
=> Finished 'tgui-tsc' in 14.564s
[warn] packages/tgui/interfaces/MarineCasship.tsx
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
=> Target 'tgui-prettier' failed in 20.35s, exit code: 1
=> Finished 'tgui-eslint' in 22.51s
=> Target 'tgui-lint' failed
=> Target 'lint' failed

@@ -213,6 +212,8 @@

/mob/living/carbon/human/proc/check_self_for_injuries()
var/list/final_msg = list()
visible_message(span_notice("[src] examines [p_them()]self."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balloon alert to viewers this

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 7, 2022
comfyorange added a commit that referenced this pull request Nov 7, 2022
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 7, 2022
comfyorange added a commit that referenced this pull request Nov 7, 2022
comfyorange added a commit that referenced this pull request Nov 8, 2022
comfyorange added a commit that referenced this pull request Nov 8, 2022
comfyorange added a commit that referenced this pull request Nov 8, 2022
@tgstation-server tgstation-server added the Merge Conflict Pull request is in a conflicted state with base branch. label Nov 8, 2022
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Nov 8, 2022
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Nov 9, 2022
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Nov 9, 2022
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 9, 2022
comfyorange added a commit that referenced this pull request Nov 10, 2022
comfyorange added a commit that referenced this pull request Nov 10, 2022
comfyorange added a commit that referenced this pull request Nov 10, 2022
comfyorange added a commit that referenced this pull request Nov 10, 2022
comfyorange added a commit that referenced this pull request Nov 11, 2022
@TiviPlus
Copy link
Member

Merging because zachary isnt responding

@TiviPlus TiviPlus merged commit 79d0545 into tgstation:master Nov 12, 2022
github-actions bot added a commit that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Update Changes to server configuration options. Sprites Changes to .dmi file. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. Tools Changes to the various development tools. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants