Tele COPE #15810
Merged
Tele COPE #15810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Feature
github-actions
bot
added
the
Merge Conflict
tgstation-server
removed
the
Merge Conflict
TiviPlus
requested changes
May 14, 2024
Comment on lines
79
to
85
| /datum/fire_support/proc/select_target(turf/target_turf) | ||
| var/list/turf_list = list() | ||
| for(var/turf/spread_turf in RANGE_TURFS(scatter_range, target_turf)) | ||
| turf_list += spread_turf | ||
| for(var/i = 1 to impact_quantity) | ||
| var/turf/impact_turf = pick(turf_list) | ||
| addtimer(CALLBACK(src, PROC_REF(do_impact), impact_turf), 0.15 SECONDS * i) |
There was a problem hiding this comment.
? range_turfs is a turf only list already lol thats its benefit
There was a problem hiding this comment.
I unno, old code from mortar or something. Fixed though.
TiviPlus
requested changes
May 15, 2024
| var/list/turf_list = list() | ||
| for(var/turf/T in range(range_num, target)) | ||
| turf_list += T | ||
| var/list/turf_list = range(range_num, target) |
There was a problem hiding this comment.
RANGE_TURFS, range() returns all atoms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What's worse than a SOM engineer throwing a COPE sentry at you?
A SOM SL calling in a teleporter delivered COPE on you.
Adds the ability to summon up to 2 COPE sentries via teleporter. Like TGMC sentry/supply pods, this is enabled simply by activating the teleporter asset, and lasing like all air support.
For maints: I also reorganised the files, as it was all crammed in one giant DM. Only the stuff in the teleport.dm file is new though.
Why It's Good For The Game
While the teleporter is situationally very strong, in practical terms drop pods are SIGNIFICANTLY more useful, due to being very flexible for individual drops.
This adds a bit more utility to the teleporter, even when you're not using it to deploy troops or supplies.
Changelog
🆑
add: Campaign: Activating the teleporter asset gives access to a teleport COPE air support type
/:cl: