Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mc refactor #4983

Closed
wants to merge 20 commits into from
Closed

Mc refactor #4983

wants to merge 20 commits into from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Oct 9, 2020

About The Pull Request

Building upon the tg PR 53841
MC will agressively yield to byond ticks and will not process background sses for it

Why It's Good For The Game

Lag be gone spray
Should be tested just in case

Changelog

馃啈
refactor: refactored the master controller, removing tick lag
/:cl:

@tgstation-server tgstation-server added the Refactor Improves underlying code to make systems more modular and functional. label Oct 9, 2020
@Hughgent Hughgent added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 9, 2020
@Hughgent Hughgent requested review from psykzz and spookydonut and removed request for psykzz October 9, 2020 16:47
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 9, 2020
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 9, 2020
@spookydonut
Copy link
Contributor

tgstation/tgstation#53841

the tg pr was never finished or merged i wouldn't put us out of step with tg's MC, make the improvements upstream first.

@TiviPlus TiviPlus added the Do Not Merge Pull request should not be merged due to design conflict or being a temporary change. label Oct 10, 2020
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 10, 2020
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 12, 2020
@github-actions github-actions bot closed this Nov 20, 2020
@TiviPlus TiviPlus deleted the Mcrefactor branch February 18, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spookydonut spookydonut Awaiting requested review from spookydonut

Assignees
No one assigned
Labels
Do Not Merge Pull request should not be merged due to design conflict or being a temporary change. Refactor Improves underlying code to make systems more modular and functional. Stale Pull request is awaiting delayed author response and may be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TiviPlus @spookydonut @tgstation-server @Hughgent