Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill mesons #7199

Closed
wants to merge 3 commits into from
Closed

Kill mesons #7199

wants to merge 3 commits into from

Conversation

BraveMole
Copy link
Contributor

@BraveMole BraveMole commented Jun 27, 2021

About The Pull Request

Remove mesons from game and code

Also for everyone who say: "fix it not remove it"

This is not fixable. Period. The lighting system TGMC use is not compatible with the view_turf bit flags the mesons are using. And nothing currently in the lighting system can emulates what are mesons.
And even if i spent much more time that i want of this item to try to remake it without bugs, nothing say it's even possible to remake it in the constraint of tgmc lighting system.

2021-06-27_13-50-11_online-video-cutter.com.mp4

Why It's Good For The Game

Powergamer gear, prone to multiple bugs (OW, CAS, weird behaviour with lights). This gives a advantages only to a fraction of marines, only because they are rushing/greytiding the engie vendor.

It's limited gear, such things should come from req, not "first to come have it"

Changelog

馃啈
del: Mesons are a goner
/:cl:

@tgstation-server tgstation-server added the Removal Feature removal due to maintainibility or design direction. label Jun 27, 2021
@Jeff-jefferson-jeffery

This comment has been minimized.

@RenGusta

This comment has been minimized.

@BraveMole

This comment has been minimized.

@ilikesaying
Copy link

now remove xenos xray and only give them thermal vision

@tgstation-server tgstation-server added the Map Edit One or more changes to .dmm files. label Jun 27, 2021
@RenGusta
Copy link
Contributor

The video in the PR description is the one demonstrating a bug with tac binos, not the one with mesons. Don't be misleading in your PR.

I'd post the correct one but the file size is too large.

Here's a link anyway. https://cdn.discordapp.com/attachments/504094319075131402/858691433967255582/2021-06-27_13-51-58_online-video-cutter.com.mp4

@BraveMole
Copy link
Contributor Author

The video in the PR description is the one demonstrating a bug with tac binos, not the one with mesons. Don't be misleading in your PR.

I'd post the correct one but the file size is too large.

Here's a link anyway. https://cdn.discordapp.com/attachments/504094319075131402/858691433967255582/2021-06-27_13-51-58_online-video-cutter.com.mp4

It's a bug due to combination of mesons + binos, not just binos.

mesons are bugged out, period

@Georgeur
Copy link

it is practically impossible to not use the bug so long as you're using binos and have mesons, the only reliable way I've found to cancel the bugged effect is by using a rail scope.

but even with some armor like PAS or Baldur, the effect is virtually 100% night vision.
this is with PAS and mesons, without the bug.
image

@sunofang
Copy link
Contributor

Okay. And how are you gonna see where you are plasma cutting to?

@BraveMole
Copy link
Contributor Author

Okay. And how are you gonna see where you are plasma cutting to?

You just don't. Don't see how that would make a difference anyway

@EvilMelonTheSecond
Copy link
Contributor

Just add it to req bro.

On a serious note mesons are really valuable for engineers and the only way of using jaeger with baldur. I would much rather have a fix or a roundstart engi gear type of restriction instead of nuking it.

@Cowbin
Copy link
Contributor

Cowbin commented Jun 27, 2021

I agree with EvilMelonTheSecond. Just make mesons an item in engie vendors, as they are extremely useful for engineers and plasmacutters. If you want to lower the amount of greytiding just take them away from anywhere but engineer kit. Any other complaints about them should be bugfixes, not removals.

@AbsoluteJerry
Copy link

Objectively, this is a bad PR. 120% not biased engineer main.

@bowlofcereal

This comment has been minimized.

@Katsera
Copy link

Katsera commented Jun 27, 2021

this is a massive nerf to CAS. Not even counting the bug that lets you see everything, just being unable to see in the dark kills CAS completely.

@Ieteihowmee
Copy link

How about no. What unintended affect has what had on mesons? I have not yet seen it or experienced it. Now test that bug with PAS on and no light, I bet xenos will not show up. Fix it instead of removing it.

@Ieteihowmee
Copy link

it is practically impossible to not use the bug so long as you're using binos and have mesons, the only reliable way I've found to cancel the bugged effect is by using a rail scope.

but even with some armor like PAS or Baldur, the effect is virtually 100% night vision.
this is with PAS and mesons, without the bug.
image

Binos cause the issue? Interesting. I was thinking in the video brave posted that he was able to see the runner because of the baulder module. Since you CAN see them in some dark spots with mesons but only as far as light will emit and a few tiles out. Interesting. Still, should just fix it instead of remove it. More marine nerfs hold dang.

@Katsera

This comment has been minimized.

@Alexeivichi

This comment has been minimized.

@BraveMole

This comment has been minimized.

@MLGTASTICa
Copy link
Contributor

this is a massive nerf to CAS. Not even counting the bug that lets you see everything, just being unable to see in the dark kills CAS complet

Dude , CAS is not meant to be able to be used through the dark , its an actual balance change , you need to light up a area if you want to use CAS

@Katsera

This comment has been minimized.

@AbsoluteJerry

This comment has been minimized.

@AnCopper

This comment has been minimized.

@ZahaSanko

This comment has been minimized.

@lovegreenstuff

This comment has been minimized.

@AbsoluteJerry

This comment has been minimized.

@Captiajoe
Copy link

Captiajoe commented Jun 27, 2021

The mesons give you view of the dark tiles for sure, however you cant see anything that is on that tile, xenos or item until a light is in range of it, try to see a xenos in your corner of your screen that is bathed in darkness, than when it gets close to your armor light you will than see it on mesons and without it, unless that was changed. The fact is the mesons just make the dark tiles into a tile you can see there is structures and a floor, it doesnt let you see xenos in complete pitch black darkness.
-edit: I see where the bug comes in, and how does this bug appear, is it only when you turn on and off a mesons?

@Georgeur
Copy link

It does effectively give you night vision, and if you can't hold two separate beliefs at once, like mesons are unbalanced/bugged, but also we should have something to look for cave openings and building layouts.
Try to use a few braincells, they're not wrong that mesons would be god awful to "fix".

Copy link
Member

@SplinterGP SplinterGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably said nuuh, but fix the bugs not remove it, its completely possible to fix them as they were sometimes already fixed before.

@bowlofcereal

This comment has been minimized.

@Ragecrabbo

This comment has been minimized.

@usnpeepoo

This comment has been minimized.

@Ieteihowmee

This comment has been minimized.

@TiviPlus
Copy link
Member

Next person to comment off topic means noone gets to comment but me

1 similar comment
@TiviPlus
Copy link
Member

Next person to comment off topic means noone gets to comment but me

Comment on lines -13 to -14
vision_flags = SEE_TURFS
lighting_alpha = LIGHTING_PLANE_ALPHA_MOSTLY_VISIBLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why arent you just removing the lighting alpha changes so you can only see as far as the light shines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Edit One or more changes to .dmm files. Removal Feature removal due to maintainibility or design direction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet