Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization #42

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Modernization #42

merged 2 commits into from
Oct 14, 2020

Conversation

Absolucy
Copy link
Contributor

@Absolucy Absolucy commented Oct 11, 2020

  • Use thiserror over failure - cleaner code.
  • Use flume instead of std::mpsc - better performance, 100% safe
  • Use the rust-crypto crates (md-5, sha-1, sha2) over crypto-hash - slightly more complex code, but one less openssl dependency (sadly, mysql still pulls in openssl)
  • Get rid of all the extern crates
  • Use serde with the "derive" feature over serde_derive
  • Update mysql to 20.0
  • Make the file_read/append/write used buffered IO, write/append will ensure that filesystem metadata is synchronized.

@spookydonut
Copy link

@aspenluxxxy conflicts

@Absolucy
Copy link
Contributor Author

@spookydonut fixed

@spookydonut spookydonut merged commit a7e803a into tgstation:master Oct 14, 2020
@Absolucy Absolucy deleted the ooga-booga branch October 14, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants