Swarm Murder University #1461
Merged
Swarm Murder University #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract bulk of actions into ServerUpdater class, based on old ServerUpdateInitiator. - Add new ServerUpdateIntiator for AdministrationController These changes break some interdependencies between SwarmService and Server. - Correct the meaning of IRestartHandler.HandleRestart's second argument. - Eliminate usage of SetupApplication's static IAssemblyInformationProvider and IIOManager.
- Set all requests to use assemblyInformationProvider UserAgent by default. - Removed DefaultIOManager's dependency on IAssemblyInformationProvider. - Fixed bad Dispose scope for requests under construction in SwarmService.
- No longer registers for restart unnecessarily - Fixed infinite wait when committing update - Fixed unregistering without a registration - Abort updates if the controller health check fails
|
this is the definition of cushy ivy league school |
… condition in SwarmRpcMapper calls
- Fix non-swarm mode updates. - Add node ID logging context for live test.
Codecov Report
@@ Coverage Diff @@
## dev #1461 +/- ##
==========================================
- Coverage 91.63% 91.59% -0.05%
==========================================
Files 564 568 +4
Lines 116483 116644 +161
==========================================
+ Hits 106744 106835 +91
- Misses 9739 9809 +70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of tests, fixes, and improvements regarding the swarm system. Work on #1459 but I wouldn't call it extensive yet.
🆑 Configuration
The new config version is 4.6.0.
Added
Swarm:UpdateRequiredNodeCountoption. This is the number of additional nodes a swarm controller expects to be present for an update./:cl:
🆑
Reduced surface area for potential failure in distributed swarm server updates.
Fixed potential deadlock if a swarm controller abandons a node that is waiting to commit an update.
/:cl:
🆑 HTTP API
Added error code 28 for if an update can't start due to a server swarm not being fully populated (responds with HTTP 424) .
/:cl: