Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 error on entering a registered Windows login with invalid password #1526

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Jun 7, 2023

Fixes #1521

🆑
Fixed an internal error that could occur if an incorrect password was entered for a registered Windows user.
/:cl:

Merging with [TGSDeploy]

@Cyberboss Cyberboss added Fix Fixes incorrect functionality Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) Priority: High Fix as soon as possible Controller Issue Issue regarding the HTTP request controllers Windows Only Issue only applies to Windows deployments labels Jun 7, 2023
@Cyberboss Cyberboss added this to the v5.12.5 milestone Jun 7, 2023
github-actions[bot]
github-actions bot previously approved these changes Jun 7, 2023
@Cyberboss Cyberboss added Priority: CRITICAL Alarm clock up. Fix immediately and removed Priority: High Fix as soon as possible labels Jun 7, 2023
@Cyberboss Cyberboss enabled auto-merge June 7, 2023 22:15
@Cyberboss Cyberboss changed the base branch from dev to master June 7, 2023 22:34
@Cyberboss Cyberboss dismissed github-actions’s stale review June 7, 2023 22:34

The base branch was changed.

@Cyberboss Cyberboss disabled auto-merge June 7, 2023 23:08
@Cyberboss Cyberboss enabled auto-merge June 7, 2023 23:24
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1526 (d00410e) into master (40ae844) will increase coverage by 0.11%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
+ Coverage   72.44%   72.55%   +0.11%     
==========================================
  Files         357      357              
  Lines       21956    21959       +3     
==========================================
+ Hits        15905    15932      +27     
+ Misses       6051     6027      -24     

@Cyberboss Cyberboss merged commit b86d678 into master Jun 8, 2023
75 checks passed
@Cyberboss Cyberboss deleted the 1521-FixIncorrectPasswordSystemUser branch June 8, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controller Issue Issue regarding the HTTP request controllers Fix Fixes incorrect functionality Priority: CRITICAL Alarm clock up. Fix immediately Security Issue pertaining to Authentication/Authorization or NTC (Never Trust the Client) Windows Only Issue only applies to Windows deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering an invalid password for a system login triggers an internal server error
1 participant