Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API deprecation for Heartbeat fields #1546

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

Cyberboss
Copy link
Member

🆑 HTTP API
Deprecated DreamDaemon model fields dumpOnHeartbeartRestart and heartbeatSeconds in favor of dumpOnHealthCheckRestart and healthCheckSeconds respectively.
/:cl:

@Cyberboss Cyberboss added HTTP API The JSON Web API that controls the server Controller Issue Issue regarding the HTTP request controllers Migration Requires or performs a database migration labels Jun 14, 2023
@Cyberboss Cyberboss added this to the v5.13.0 milestone Jun 14, 2023
@Cyberboss Cyberboss enabled auto-merge June 14, 2023 05:58
github-actions[bot]
github-actions bot previously approved these changes Jun 14, 2023
- Migrate database to these
- Deprecate Heartbeat fields
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@7db8db0). Click here to learn what that means.
The diff coverage is 100.00%.

@@          Coverage Diff           @@
##             dev    #1546   +/-   ##
======================================
  Coverage       ?   92.95%           
======================================
  Files          ?      591           
  Lines          ?   121453           
  Branches       ?        0           
======================================
  Hits           ?   112902           
  Misses         ?     8551           
  Partials       ?        0           

@Cyberboss Cyberboss merged commit 790f580 into dev Jun 14, 2023
74 checks passed
@Cyberboss Cyberboss deleted the HealthCheckHeartbeartContinuation branch June 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controller Issue Issue regarding the HTTP request controllers HTTP API The JSON Web API that controls the server Migration Requires or performs a database migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant