Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.12.7: Fix deployments failing if creating GitHub deployments was enabled and GitHub returned bad data #1579

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Jun 29, 2023

馃啈
Fixed deployments failing if creating GitHub deployments was enabled and GitHub returned bad data.
Fixed deployments failing if the GitHub repository ID could not be retrieved under certain circumstances.
Fixed deployments failing if posting test merge comments was enabled and the GitLab request failed.
/:cl:

@Cyberboss Cyberboss added Fix Fixes incorrect functionality Area: Compiler With regard to managing the deployment process Component Issue Issue regarding the service components labels Jun 29, 2023
@Cyberboss Cyberboss added this to the v5.12.7 milestone Jun 29, 2023
@Cyberboss Cyberboss enabled auto-merge June 29, 2023 18:49
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2023
@Cyberboss Cyberboss changed the title Fix deployments failing if creating GitHub deployments was enabled and GitHub returned bad data. Fix deployments failing if creating GitHub deployments was enabled and GitHub returned bad data Jun 29, 2023
@Cyberboss Cyberboss added the Release This is a release pull request label Jun 29, 2023
@Cyberboss Cyberboss changed the title Fix deployments failing if creating GitHub deployments was enabled and GitHub returned bad data Release v5.12.7: Fix deployments failing if creating GitHub deployments was enabled and GitHub returned bad data Jun 29, 2023
@Cyberboss Cyberboss disabled auto-merge June 29, 2023 19:30
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #1579 (f2f9872) into master (8a1ecba) will increase coverage by 0.02%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
+ Coverage   72.79%   72.82%   +0.02%     
==========================================
  Files         352      352              
  Lines       21925    21937      +12     
==========================================
+ Hits        15960    15975      +15     
+ Misses       5965     5962       -3     

@Cyberboss Cyberboss merged commit 6338a2e into master Jul 1, 2023
74 checks passed
@Cyberboss Cyberboss deleted the DeploymentsNeedToChill branch July 1, 2023 21:16
@Cyberboss Cyberboss modified the milestones: v5.12.7, v5.13.0 Jul 15, 2023
@Cyberboss Cyberboss modified the milestones: v5.13.0, v5.12.7 Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Compiler With regard to managing the deployment process Component Issue Issue regarding the service components Fix Fixes incorrect functionality Release This is a release pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant