Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docker image to debian 12 #1591

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Updates docker image to debian 12 #1591

merged 1 commit into from
Jul 14, 2023

Conversation

alexkar598
Copy link
Member

@alexkar598 alexkar598 commented Jul 11, 2023

馃啈
Docker image is now based off of debian bookworm(12).
/:cl:

It's quite silly and funny. Dunno if this is a breaking change or not. TGS itself should keep working but event scripts might feel a bit sad. This is mostly because I want the latest toys from 12

@Cyberboss Cyberboss self-assigned this Jul 11, 2023
@Cyberboss Cyberboss added the Docker Related to the Docker image label Jul 11, 2023
Copy link
Member

@Cyberboss Cyberboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to release this change without first running the test suite on whatever base image docker uses. For that, we'll need a separate Dockerfile. Running it with just Release, Sqlite, System Watchdog should be sufficient.

@Cyberboss Cyberboss added this to the v5.13.0 milestone Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1591 (3401d83) into dev (a1f6812) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1591      +/-   ##
==========================================
- Coverage   92.68%   92.65%   -0.03%     
==========================================
  Files         597      597              
  Lines      122171   122171              
==========================================
- Hits       113229   113203      -26     
- Misses       8942     8968      +26     

@Cyberboss
Copy link
Member

Fuck it

@Cyberboss Cyberboss merged commit 134edd0 into dev Jul 14, 2023
111 of 112 checks passed
@Cyberboss Cyberboss deleted the alexkar598-patch-1 branch July 14, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Related to the Docker image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants