xenomorph inventory uses old UI or something #34369
Labels
Consistency Issue
The dev team didn't think of everything
UI
We make the game less playable, but with round edges
Comments
WJohn
added
Consistency Issue
|
Wjohn tags it of course. But uh how did you cuff a xenomorph |
Merged
optimumtact
pushed a commit
that referenced
this issue
Nov 27, 2020
Partiallyfixes #34369 Modified xenomorph, monkey, dog, and parrot strip menu UI to be like humanoids'. Also fixed an issue with parrot strip menu where it wouldn't refresh once you removed its headset, and fixed an inconsistency where human handcuff/legcuff removal buttons were different.
MMMiracles
added a commit
to MMMiracles/tgstation
that referenced
this issue
Dec 4, 2020
* Automatic changelog generation for PR tgstation#54783 [ci skip] * Makes it so living crate creatures can pass plastic flaps as god intended. (tgstation#55088) * Automatic changelog generation for PR tgstation#55088 [ci skip] * improves away missions and load times (tgstation#55055) * improves away missions and load times * snowed inn * Automatic changelog generation for PR tgstation#55055 [ci skip] * Fixes cryogenics infinite gas deletion (tgstation#55068) * cryo fixes and cleanup Move magic numbers to defines Fixes cryo deleting 100L of gas each time it transfers Remove unneeded/unused variables Moves gas all gas consumption to process_atmos delta_time in process_atmos * simplify consume_gas * Automatic changelog generation for PR tgstation#55068 [ci skip] * Hygienebots de/construct and behave like the other simplebots. (tgstation#55089) Adds simple deconstruct steps to the hygiene bot assembly, as well as adds a simple crafting menu option to craft one. Also, corrects an issue with hygienebots not needing to be opened in order to be emagged. They now need to be emagged to be opened with a screwdriver, then emag the open panel in order to emag the robot, just like every other robot. * Automatic changelog generation for PR tgstation#55089 [ci skip] * Reload verbs when the client goes into a new mob (tgstation#55106) Try this experiment at home: 1.Ctrl shift click your ghost 2.Notice that you still have the Ghost tabs, and you don't see OOC > Ghost, uh oh. This happens for more than ctrl-shift-clicking, it happens a lot with event mobs. This reloads verbs on /mob/Login, aka when the client goes into a new mob (or when they reconnect). * Automatic changelog generation for PR tgstation#55106 [ci skip] * Moves grown food to newfood (tgstation#55040) Moves grown food to newfood Gives trash element support for callbacks for item creation override * Automatic changelog generation for PR tgstation#55040 [ci skip] * shuttle catastrophe now cant trigger if it already happened (tgstation#55114) Shuttle catastrophe now cant trigger if it already happened * Automatic changelog generation for PR tgstation#55114 [ci skip] * Automatic changelog compile [ci skip] * Foam darts and other unembeddable bullets will no longer leave ghost shrapnel (tgstation#54994) Projectiles are assigned the ability to try embedding by the presence of a shrapnel_type variable being set on them, whether or not they actually have a set of embedding stats in their embedding var. By default, children of /obj/projectile/bullet have a shrapnel type set to a generic embedded bullet item, including things like foam darts and lollypop projectiles which shouldn't be able to embed (and certainly not embed as a bullet). While they had their embedding vars set to null, they still had their shrapnel_type set to the embedded bullet type, meaning shooting a person with a dart gun or whatever would leave a failed shrapnel item on the ground where they weren't supposed to. This fixes that by requiring both a defined shrapnel_type AND a defined embedding var for the embedding stats. Any projectiles without both won't be able to try embedding. I also manually put 'shrapnel_type = null' on any bullet subtypes with embedding = null just to be safe and for consistency. * Automatic changelog generation for PR tgstation#54994 [ci skip] * Automatic changelog compile, [ci skip] * removes a direct use of Destroy() (tgstation#55043) * cursed * Update code/datums/mutations/antenna.dm Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> * Update code/datums/mutations/antenna.dm Co-authored-by: spookydonut <github@spooksoftware.com> * Update code/datums/mutations/antenna.dm Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> * Automatic changelog generation for PR tgstation#55043 [ci skip] * additions no longer runtime on medical kiosks. (tgstation#55125) * UNIQUE_RENAME respects labels (tgstation#55121) * Automatic changelog generation for PR tgstation#55121 [ci skip] * path funeneee (tgstation#55119) * Automatic changelog generation for PR tgstation#55119 [ci skip] * Lowers Stasis Bed Overlay below objects to prevent overlay issues. (tgstation#55082) * Automatic changelog generation for PR tgstation#55082 [ci skip] * one character fix (tgstation#55067) * Automatic changelog generation for PR tgstation#55067 [ci skip] * Fixing the point emote being both usable and unusable (tgstation#55063) * Automatic changelog generation for PR tgstation#55063 [ci skip] * Fixes tool implant tools being storable in boxes (tgstation#54914) * Moves storing tool implant items to use the drop hotkey rather than a dropped item event * de-debugging * Automatic changelog generation for PR tgstation#54914 [ci skip] * Makes APCs not cause runtimes when placed in space (tgstation#55045) * Automatic changelog generation for PR tgstation#55045 [ci skip] * This makes me sad (tgstation#55007) * Automatic changelog generation for PR tgstation#55007 [ci skip] * Detect if ghost reentered the brain (tgstation#54975) * Automatic changelog generation for PR tgstation#54975 [ci skip] * make sure slowdown effects get removed when items are unequipped (tgstation#54947) * Fixes PDA bombing have equal chances to work on PDAs without manifest access vs PDAs with it (tgstation#55036) * Makes extra difficulty actually work 0 * Actually fixes it as of what Fikou suggested * no space, sorry Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> * Automatic changelog generation for PR tgstation#55036 [ci skip] * Deconstructed computer consoles no longer delete their own circuits. (tgstation#55126) * Feex * Remove newline * Automatic changelog generation for PR tgstation#55126 [ci skip] * Fixes dish drives spitting out components on interact. (tgstation#55065) * stop vomiting components ok mr dishdrive * remember to do the dishes! * lazyadds and lazylens * actually lazy now * Automatic changelog generation for PR tgstation#55065 [ci skip] * man adds a single ? (tgstation#55129) * Automatic changelog generation for PR tgstation#55129 [ci skip] * Prevents mecha drills from stacking do_afters on the same target. (tgstation#55145) * Feex * Feex 2.0 Feexlectric Feexaloo * Whitespace purge * Automatic changelog generation for PR tgstation#55145 [ci skip] * tgui: Safe (tgstation#55109) This PR refactors safes and brings their UI from html to tgui based on the PR above. Paradise has more features for safes than us, and these features were not ported along to accommodate feature freeze. Only our current safe features settings were refactored, for example number of tumblers stays 2, no extra safe information on examine and safe codes are not generated on paper for command. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR tgstation#55109 [ci skip] * Fixes lightbulb injections (tgstation#55132) Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com> Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> * Automatic changelog generation for PR tgstation#55132 [ci skip] * Fixes tgstation#55112 - Swapping items no longer eats things (tgstation#55122) Quick swapping items no longer hides them in the mobs contents * Automatic changelog generation for PR tgstation#55122 [ci skip] * Automatic changelog compile [ci skip] * Refactors Pastries into newfood. (tgstation#54996) Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> Co-authored-by: Floyd <Floydje123@hotmail.com> * Automatic changelog generation for PR tgstation#54996 [ci skip] * Humans have more complicated body temperatures (tgstation#54550) This changes how carbon/humans stabilize body temperature, and changes how damage and wounds are applied based on temperature. Humans now have a core body temperature along with body temperature. The core temperature is used for natural stabilization and what viruses like fever and shivers target by raising or lowing the core temperature of the mob. The standard body temperature still exists and acts exactly the same for most items at this time but is now treated as surface temperature in humans. Damage from body temperature for humans is now based on the core temperature instead of body temperature now. Humans will now receive burn wounds when the body (surface) temperature is to high for to long. This causes you to see alerts for the area temperature before you take damage in most cases improving visibility of dangerous situations. * Automatic changelog generation for PR tgstation#54550 [ci skip] * Fixes chem and addiction scans, null checks for addiction_list (tgstation#55105) So tgstation#54797 changed addiction_list to instantiate as a null instead of a list. Turns out a few things relied on the list existing! Things like health analyser/medical kiosk chem and addiction scans broke, and smokers would no longer get addicted! Made a few places check if addiction_list is null before continuing. (Lemon's note, refactored some code to make it cleaner/removed some unneeded loop typechecks) * Automatic changelog generation for PR tgstation#55105 [ci skip] * Moves sorting of crew console listings to clientside + refactors (tgstation#55124) Moves the sorting of the entries within the crew console to be clientside. There's no reason to have this serverside. I've also refactored the UI data code for the crew console in general, reduced code duplication and reduced unnecessary data transfer of nulls. * Automatic changelog generation for PR tgstation#55124 [ci skip] * CanUseTopic() refactor. (tgstation#54747) * CanUseTopic() refactor. * Forgot about default_can_use_topic. Tested and working. * Update bin.dm * no-nonsense. * Automatic changelog generation for PR tgstation#54747 [ci skip] * tgui: Fix issues detected by SonarQube (tgstation#55098) * tgui: Fix issues detected by sonarqube * MacOS compatibility * Rebuild tgui * Nerfs GBP gain (tgstation#55038) Basically no one ever hits the lower limit and people have fucking bank at this point. * Replace tgalert with tgui_alert (tgstation#55157) Adds TGUI-based alerts to replace the old tgalert system. Replaces all uses of tgalert with tgui_alert except for one, the 'Report Issue' button, as people were (understandably) concerned that this button using tgui will prevent a tgui bug from being easily reported. These windows have a nice little progress bar indicator of how much time they have left, and will automatically close themselves after this time elapses. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR tgstation#55157 [ci skip] * Fixes template use for 'Report Issue' button in-game + show [s] testmerged prs (tgstation#55135) Fixed and improved the bug report template use when the 'Report Issue' button is used in-game. It now uses the correct template location, as well as automatically filling in the round ID and testmerges. We also now show [s] PRs that are testmerged, as ok-d by oranges, as this is an unofficial label that anyone can apply and doesn't necessitate hiding. It also makes debugging rounds where this was present but not reported more difficult. * Automatic changelog generation for PR tgstation#55135 [ci skip] * Feex (tgstation#55144) For whatever reason we hardcoded the health value for drills at 200 brute damage before they can gib. 200 brute damage was picked as it was double the max health of /mob/living/carbon/whatever and double the max health was like, the cap on brute damage when someone is really, really, really, really dead. Enter simplemobs. Their max health is regularly under 100, which means a hardcoded value of 200 brute damage to trigger gibbing effects is bad. Not that it matters anyway, because simplemobs also brute damage cap at maxHealth instead of maxHealth * 2 so the only simplemobs that could be gibbed by mech drills are those with 200 or more health. This has been changed. Simplemobs now cap out at maxHealth * 2 damage, in line with all other /mob/living while drill code has been changed to check for maxHealth * 2 when gibbing instead of a hardcoded 200. * Automatic changelog generation for PR tgstation#55144 [ci skip] * Automatic changelog compile [ci skip] * Fixes cyborgs in general replenishing stack modules from external sources (tgstation#54935) * Cyborg stack fix - Makes cyborgs capable of recycling floor tiles again * Touches up module code - Makes module code slightly more OOP-compliant - Speeds up module creation by an imperceptable amount - Reworks how borg modules handle stacks * Automatic changelog generation for PR tgstation#54935 [ci skip] * Fixing non wiz phased mobs. (tgstation#55162) Wrong proc path, also qdel ref issue for shadow walk holder. This will close tgstation#55141 and close tgstation#55142 fix: Nightmares and some other critters no longer delete themselves once they stop phasing. * Automatic changelog generation for PR tgstation#55162 [ci skip] * Fixes forced speech nanite oversight (tgstation#55164) All of the stunning emotes were blacklisted from the forced speech program. However, *faint was not added this to the list, and this is an oversight. This is a simple one line fix to add it to the blacklist. * Automatic changelog generation for PR tgstation#55164 [ci skip] * Accidental Consumption post-food refactor cleanup (tgstation#55152) Renames a bunch of vars to be more descriptive Removes old references to snacks Updates some code slightly * Automatic changelog generation for PR tgstation#55152 [ci skip] * Remove the hyphen from the default value of the github url string (no longer -tg-station) (tgstation#55136) * Fixes an adminPM dead end eating replies (tgstation#55127) If you tried to reply to an admin that had deadminned while you were typing you would get an error and your message was eaten. Now sends to MessageNoRecipient if theres an open ticket, or prints a warning and the message in chat if there isn't. * Automatic changelog generation for PR tgstation#55127 [ci skip] * Fixes picked up bees, again (tgstation#55053) Bees don't actually have a set icon state, their entire existence is their mutable appearance. This creates problems when something checks for the bee's icon state, like mob_holders. So, this PR sets their icon_state to the corresponding base bee icon on initialization. Visually identical to before, because the overlays / mutable appearance covers it, but their icon_state is no longer null. * Automatic changelog generation for PR tgstation#55053 [ci skip] * Pixels peeve about the galaxy suit (tgstation#55165) Added a few pixels to the left and right sprites of the galaxy suits. * Automatic changelog generation for PR tgstation#55165 [ci skip] * Fixes some food item sizes (tgstation#55174) * Automatic changelog generation for PR tgstation#55174 [ci skip] * tgui: Stacking Machine Console and Safe UI fix (tgstation#55171) This PR refactors Stacking Machine Console from using html based UI to tgui with some code cleanup and documentation. Also fixes a bug I noticed when using Stacking Machine Console - some materials could get stuck there if they were number subtypes (for example /obj/item/stack/sheet/metal/twenty), because console did not check for their merge_type for releasing like stacking machine itself does when the sheet is put inside. This is fixed now. Also fixes a small safe UI bug, where some buttons could be hard to press due to the dialer image being too close to the buttons. Bundling this together to prevent merge conflicts with other tgui PRs. Fixes tgstation#55169 * Automatic changelog generation for PR tgstation#55171 [ci skip] * Merge type variable fixes and unit test (tgstation#55173) This PR fixes a case where certain materials caused issues when working with stacking machines, because they did not have set merge_type from the get go, which meant that initial() of that variable returned null. To clarify further - if /obj/item/stack does not have set merge_type, it is generated merge_type upon Initialize(), which is the same as its typepath. For example, currently /obj/item/stack/sheet/bluespace_crystal does not have any merge_type set, and it is given merge_type = /obj/item/stack/sheet/bluespace_crystal upon Initialize(). Each Initialize(). Again and again. There are quite a bit of these cases in the codebase, especially if its some older code. I have gone through them and set all of them their set merge_type, which they would inevitably receive anyway upon initializing and it fixes a bug mentioned above. To prevent this happening again, I have also included unit test to check if merge types are set for stacks, included exceptions are usually abstract paths like /obj/item/stack/sheet/mineral, which contains zero behavior on its own and does not spawn unless done via admin tools. * Automatic changelog generation for PR tgstation#55173 [ci skip] * Being flashed by a portable flasher is now logged (tgstation#55137) Getting stunned by a portable flasher will now be reflected in your attack logs * Fixes Improvised Jetpack (+New custom icons) (tgstation#55177) This fixes the improvised jetpack, which currently cannot be activated. Fixed [tgstation#50396](tgstation#50396) The code change was very minor and everything seems to work properly now. Bonus: New custom icons for this item, better representing what it most likely would look like * Automatic changelog generation for PR tgstation#55177 [ci skip] * Removes a source of ian harddels, keeps mcgruffs bed discription from getting overwritten at roundstart, moves the bed claiming feature to just the dogbed typepath, none of the subtypes, this applies to buckling too (tgstation#55158) Removes a source of ian harddels, keeps mcgruff's bed description from getting overwritten at roundstart, moves the bed claiming feature to just the dogbed typepath, blacklisting subtypes. This applies to buckling too. This means that a dogbed can only ever belong to one dog. Fuck you. Remake of tgstation#54892, github doesn't like force pushes, not sure why * Automatic changelog generation for PR tgstation#55158 [ci skip] * Fixes cleric mace handles (tgstation#55163) * Automatic changelog generation for PR tgstation#55163 [ci skip] * Fixes male underwear/shirts poking through clothes (tgstation#55139) While investigating a strange intermittent issue with skirts and such randomly losing a pixel in the crotch they weren't supposed to, I found another underwear/undershirt issue. Female characters and plural characters with a female bodytype wearing mens underwear and a fitted outfit would have an errant pixel from the undershirt/underwear show through the crotch/armpits where the outfit lost pixels due to fitting. Underwear and undershirts now undergo the same pixel fitting as other clothes to ensure this doesn't happen. * Automatic changelog generation for PR tgstation#55139 [ci skip] * Automatic changelog compile, [ci skip] * Updated strip menus (tgstation#55094) Partiallyfixes tgstation#34369 Modified xenomorph, monkey, dog, and parrot strip menu UI to be like humanoids'. Also fixed an issue with parrot strip menu where it wouldn't refresh once you removed its headset, and fixed an inconsistency where human handcuff/legcuff removal buttons were different. * Automatic changelog generation for PR tgstation#55094 [ci skip] * Fixes incapacitating sleep test failure, general test touch ups. (tgstation#55196) Fixes the random incapacitating sleep test failure Tests now provide the option to use a custom turf, by default uses plasteel tiles instead of space Tests now reserve turf instead of just using a corner in CentCom (which had unaccounted for tiles) * Working on unit test related issues grants 6 GBP, automatically add tag (tgstation#55199) Unit tests (a label I recently added) will now give 6 GBP. This label should be added to anything that adds a new unit test, even on features. * Makes swarmers and morphs ghost-visible in the orbit menu (tgstation#55191) Makes Morphs and Swarmers have their own part of the orbit menu, like other visible antagonists. Given pretty much every other ghost-obvious antagonist is, it's more of an oversight that you couldn't. * Automatic changelog generation for PR tgstation#55191 [ci skip] * HFR runtime fix (tgstation#55189) * Automatic changelog generation for PR tgstation#55189 [ci skip] * Fixes improvised jetpacks working as infinite one tick boosters (tgstation#55202) Fixes improvised jetpacks working as infinite one tick boosters allow_thrust is used as a check when the jetpack is toggled on to see if it should be allowed to turn on. This line needs to return the parent call instead of presuming it passes. * Automatic changelog generation for PR tgstation#55202 [ci skip] * Proto Nitrate reaction fix (tgstation#55188) Fix runtime with proto_nitrate reaction with trit * Automatic changelog generation for PR tgstation#55188 [ci skip] * fixes ageusia (tgstation#55187) * Automatic changelog generation for PR tgstation#55187 [ci skip] * recolored skeleton sprites (tgstation#55185) skeletons no longer have eye sprites i recolored skeleton sprites a bit * Automatic changelog generation for PR tgstation#55185 [ci skip] * Changes grenade proc names to be more clear (tgstation#55181) Grenades have, for the longest time, used the proc name preprime() to refer to arming a timed grenade so that it will boom in a few seconds, and prime() to refer to the grenade actually going boom (or releasing foam or anything else grenades do when they go off). This was very confusing, so now these two procs are called arm_grenade() and detonate(). * Fixes Ghost Dynamic Abductors (tgstation#55176) Fixes an issue where an abductor team was created every time a midround antagonist was created by Dynamic, even if it wasn't Abductors. This was simply due to some misplaced code. * Automatic changelog generation for PR tgstation#55176 [ci skip] * adds broken states to grass (tgstation#55108) grass now gets baseturfs adds a damaged icon for sand * Automatic changelog generation for PR tgstation#55108 [ci skip] * Mech Ammo now properly respects ammo for custom materials. (tgstation#55095) Mech code now does a basic check for the amount of remaining ammo to adjust the amount of custom materials of an ammo container based on the remaining ammo against the original amount of ammo. When the ammo runs out, it's hard-set to 2000 iron as that's the value of the sheet of iron that it gets set to by the end. * Automatic changelog generation for PR tgstation#55095 [ci skip] * taming improvements (tgstation#55086) tame var is now set to true on the tamed proc, not right before the tamed proc in feeding proc so if an admin atom proc calls tamed the mob is tamed vatbeast no longer overrides its faction to neutral because it already sets the action to the tamer's * Automatic changelog generation for PR tgstation#55086 [ci skip] * Hauberoach's now properly give correct feedback if you're immune to their headspike. (tgstation#55079) Hauberoaches now give a different, clearer line of dialog when stepped on by a pierce immune carbon mob. * Automatic changelog generation for PR tgstation#55079 [ci skip] * Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it (tgstation#55076) /obj/effect/ex_act had several different re-definitions to make it a noop. The original definition would randomly delete it, which is bad news when a lot of /obj/effects are just that--effects, that shouldn't be blown up. The ones that actually do want to be blown up (like decals) already have their own implementations. The one in place was never ran, and nobody had problems with it. * Fixes Issues Regarding Finding Spider and Swarmer Spawns (tgstation#55054) This PR fixes the issue where people couldn't teleport to spider egg clusters using the notification. It also adds both the swarmer beacon and spider egg clusters to the ghost orbit menu. This should make it easier to find instances of both in cases where a player might miss the initial notification. * Automatic changelog generation for PR tgstation#55054 [ci skip] * Fixing robot upgrades sometimes not being removed from lists. (tgstation#54842) * APC Fixes Pt. 1: Standardizes MetaStation APCs (tgstation#55060) * add showers to icebox and pubby atmos (tgstation#55190) * Automatic changelog generation for PR tgstation#55190 [ci skip] * Fixed cooling in the IceBox RD Server Room (tgstation#54998) * More Map Fixes (tgstation#55204) * fix pubby's incinerator errors, fix atmospheric testing room space walls * double lattice * Automatic changelog generation for PR tgstation#55204 [ci skip] * Adds N2 Canisters to the Delta Supermatter (tgstation#55205) * Does the Thing * Removes delta rad collector subtype Co-authored-by: Coffee <crashkray@gmail.coom> * Automatic changelog generation for PR tgstation#55205 [ci skip] * Automatic changelog compile, [ci skip] * Feex (tgstation#55228) Missing ! meant that if an upgrade was unequippable, it would be installable. If it wasn't unequippable, it wouldn't be installable. This is fixed. No reason I can see for cyborg upgrades to pass through the attack chain if they fail to get installed in general. Most other things stop immediately if they fail. Removed ugly if-then-else chain as a result. I'm sure someone will correct me if I'm wrong on this, it's 2:15am and I want to sleep. (Note from lemon: the logic was quite literally backwards, I am depressed) * Automatic changelog generation for PR tgstation#55228 [ci skip] * Kills the quickswap shortcut (tgstation#55209) * Automatic changelog generation for PR tgstation#55209 [ci skip] * the flight plans filed with the agency lists etc etc (tgstation#55214) Someone reported an issue on the discord where, since BYOS shuttles now have shuttle computers, they can now be hijacked partially or completely before it's actually time for evac. This has been confirmed as unintended behavior by anne, who submitted the hijack rework port, so this PR fixes that by requiring the shuttle to have at least "docked" before the ability to hijack it is available * Automatic changelog generation for PR tgstation#55214 [ci skip] * Allows dynamic game modes to be disabled (tgstation#55200) Currently for headmins to disable game modes they need to set the list of valid threats to 101, counting on the fact that the threat level doesn't go higher than 100. This is brittle, bypasses checks for having enough valid game modes, and a hacky solution at best. Made it so that setting the weight of a ruleset set to zero, be it via configs or by var-editing, will no longer draft it for picking, effectively disabling it. * sstimer no longer batches maintenance tasks to the bucket list to avoid edge cases and duplicated logic. (tgstation#55140) * sstimer no longer delays maintenance tasks if its going over its tick. This was leading to bugs if certain state operations happened while a task was delayed, furthermore if the timer subsystem was overloaded, the invoked timers list would bloat as it would never get cleared out, which would make all timer invocations take longer as they had to add to an ever growing list. * Update timer.dm * Fix error when a bucket has only one timer. * simply timer loop logic & improve timer debug string It would try to batch up linked list modifications and every issue we have ever had has been related to this, so now it just directly pulls the head of the linked list off, using bucketEject, rather then detect when it reaches the end of the linked list queue it will now just know because the bucket will be empty. All bucketCount logic has been moved to bucketEject and bucketJoin(), which should also keep that more proper. * Update timer.dm * Update timer.dm * Changes the discord verify command from .verify to ?verify This stops it conflicting with an existing set of commands that are for fun usage * Automatic changelog generation for PR tgstation#55212 [ci skip] * Automatic changelog compile, [ci skip] * Update links to Yarn documentation (tgstation#55235) Updates tgui documentation to show that yarn berry (v2) is now used. Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Adds 3 periods to the game (tgstation#55243) Fixes a single typo * Automatic changelog generation for PR tgstation#55243 [ci skip] * Cryopod cooling fix for humans (tgstation#55221) The core temp was meant to be cooled separately through the skin in cryo pods, but on inspection that interaction was skipped. This makes the core temp match skin temp in a cryo pod. * Automatic changelog generation for PR tgstation#55221 [ci skip] * Tweaks to temperature code (tgstation#55216) This is a small tweak that makes skin temp raise up faster when cold in response to ice moon being harder. This also makes a change to mobs in statis beds no long hold bed temp in some quantum lock but stops the natural stabilization. This means that is you put a frozen/superheated mob on the floor or a statis bed they will balance tot the room temp over time. The mob is not physically separate from the room in a statis bed and all life functions are still suspended. * Automatic changelog generation for PR tgstation#55216 [ci skip] * Automatic changelog compile, [ci skip] * Add AnturK's 'GC Issues' guide * Add Mothblocks's unit test documentation and guide * Add "Important Types" info from neersighted's "Common Variables and Functions" * Add some method descriptions from neer's "Common Variables and Functions" * Add dmdocs to /proc/getline * Correct some links and formatting in CONTRIBUTING * Fixes custom double-barreled shotgun back sprites (tgstation#55232) The custom double-barrelled shotgun sprite names contained a hyphen instead of an underscore, making them appear as error sprites when worn. * Automatic changelog generation for PR tgstation#55232 [ci skip] * tgui: Round Gauge (tgstation#55230) This PR introduces the wacky round gauge for showing all of your favourite metrics in half-circle format. Show off those wacky numbers, use some scary blinking lights, feel alive! I've also gone ahead and included this in the canister and tank (think internals) UIs. I've also done some refactoring of data sending from canisters because GOSH DANG it required some. * Automatic changelog generation for PR tgstation#55230 [ci skip] * Sets default food size to small. (tgstation#55210) ## About The Pull Request Fixes an oversight done during the food refactor that makes all food items normal sized instead of small. Instead of adding weight class to a bunch of individual items [(like this PR)](tgstation#55174) it just makes all food default to small unless tagged to be bigger. ## Why It's Good For The Game Being able to put 7 items on a tray instead of 4 is good, and if a food item is "too powerful", that individual item (or subtype, such as soups) can be given a larger weight class. Fixes tgstation#54818 * Automatic changelog generation for PR tgstation#55210 [ci skip] * Small refactor for medical stack items (tgstation#55213) Someone DM'd me asking a question about what the 'heal' var was for on aloe, I looked into it and realized it was an unnecessary variable that just replicated what heal_brute and heal_burn do. I then realized there was quite a lot of unnecessary copypasta in medical stack code, so I made some changes to make it neater and added some documentation in to boot * More HFR fixes (tgstation#55203) - Refractor HFR core from binary device to unary device to fix issue with cooling not properly connecting, that was deleting gases when tryed to use (only one port cooling now similar to a Thermomachine) - Small fix of GUI data where two vars were inverted * Automatic changelog generation for PR tgstation#55203 [ci skip] * Removed jQuery from snowflake devices (tgstation#55090) * Removed jQuery from snowflake menus * Update code/modules/admin/verbs/beakerpanel.dm Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> * Automatic changelog generation for PR tgstation#55090 [ci skip] * Fix the implosion compressor runtiming when the bomb is too weak (tgstation#55231) Previously, the implosion compressor would runtime when the bomb was too weak due to a badly ordered QDEL_NULL. Now, it properly returns the message. * Automatic changelog generation for PR tgstation#55231 [ci skip] * Fixes oversight where pAIs are not able to select headset radio channels from encryption keys (tgstation#55215) pAI integrated headsets are the only headsets that don't have `subspace_transmission = TRUE` - Ordinarily they're not able to install encryption keys, so this isn't necessary or useful to them. However, selecting departmental channels based on the installed encryption key is a function locked behind `subspace_transmission = TRUE` and I think the fact this flag isn't set when the pAI installs its encryption keys upgrade is most likely an oversight. This should fix all issues where pAIs get fancy encryption keys like Captain ones, but are unable to utilise any frequencies except the default ones that come pre-enabled (such as the Cap key coming with only Sec/Command enabled and having all others disabled). * Automatic changelog generation for PR tgstation#55215 [ci skip] * make gas selling use elasticity (tgstation#55192) Fix gas selling never use diminishing returns * Automatic changelog generation for PR tgstation#55192 [ci skip] * Grep for space indentation (tgstation#54850) tgstation#54604 atomizing Since a lot of the space indents are in lists ill atomize those later * Makes the usage of force_threshold in the attackby() proc for simplemobs consistent with the way it's used everywhere else (tgstation#55023) ## About The Pull Request Namely, this means that a simplemob's immunity to melee attacks of force X or lower now accounts for that simplemobs damage multipliers to various damage types. It also means that simplemobs with a force_threshold of X are now immune to melee attacks of force X or lower, not melee attacks with a force less than X (<= vs. <). ## Why It's Good For The Game **tldr; This make the code for simplemob "your stick must be this strong to deal damage" thresholds more consistent.** Xenomorphs, xenomorph larvae, barehanded monkeys, slimes, and simplemobs in general all multiply the damage of their attacks by the relevant damage resistance multiplier BEFORE checking it against the force_threshold of the simplemob they're attacking, and also check to see if their damage is <= the force_threshold of the simplemob they're attacking (instead of requiring it to be strictly < the force_threshold of the simplemob they're attacking). As for balance concerns, while this will affect juggernauts *slightly* (as they'll now be immune to force <= 10 melee weapons instead of just force < 10 melee weapons), I'm not too worried about that. What I _am_ worried about is blobbernauts, who, after this change, will be immune to brute melee weapons of force 20 or lower (due to their 0.5 brute damage multiplier). You will, of course, still be able to welder them just as effectively as you could before, but I'm worried that this could make blob-aligned blobbernauts even stronger than they already are. * Automatic changelog generation for PR tgstation#55023 [ci skip] * grep for pixelx/y = 0 varedits (tgstation#54845) Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> * Fixes Nar'Sie rune erasing bug (tgstation#55123) * Automatic changelog generation for PR tgstation#55123 [ci skip] * Init sanity unit test (tgstation#55147) tgstation/TerraGov-Marine-Corps#5326 Stemming from ParadiseSS13/Paradise#14770 Basically it just checks for bad initialize calls * Automatic changelog compile, [ci skip] * Remove redundant triple-backticks * Add a table of contents to CONTRIBUTING.md * Move Maintainer and Issue Manager guidelines into CONTRIBUTING * Update TGS DMAPI (tgstation#55259) Co-authored-by: tgstation-server <tgstation-server@users.noreply.github.com> * Slightly edit CONTRIBUTING * Single-space the /obj/item/proc/equipped docblock * Use block comments for get_turf and get_area * Use block comments for do_after and getline * Revert "Update TGS DMAPI (tgstation#55259)" (tgstation#55271) This reverts commit d2454ee. * Luxury shuttle scanner gate bugfixes and improvements (tgstation#55107) Oh man this one took me a hot second. Luxury Shuttle gates now do the following: Respect simplemobs dragging through credits so they can be considered legitimate passengers. Respect vehicles and by proxy mechs so that you don't block the narrow causway into the shuttle. Entering the gate with cash will add both yourself and the vehicle to the whitelist. Entering the gate in a whitelisted vehicle, but without paying yet will throw angry buzzing at you as expected. The shuttle will only take the correct credit count now, or at least provide the correct change. The scanner is now invincible as it LITERALLY only exists on a roundend shuttle. * Automatic changelog generation for PR tgstation#55107 [ci skip] * unfucks hitting simplemobs with melee attacks (sorry!) (tgstation#55269) Adds a single "!" to the code I added (in tgstation#55023) to make it not make most simplemobs immune to being hit with most melee weapons. * Automatic changelog generation for PR tgstation#55269 [ci skip] * Ports custom food to new food datum (tgstation#55207) Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> * Automatic changelog generation for PR tgstation#55207 [ci skip] * Maybe fixes DMAPI Update PR not triggering actions (tgstation#55297) * Revert "Removed jQuery from snowflake devices" (tgstation#55272) * Revert "Removed jQuery from snowflake devices (tgstation#55090)" This reverts commit ee47cb5. * linting SUCKS * Fixes detdrobe construction bug (tgstation#55264) Lets detectives disassemble their vendor to restock it I guess. They could rebuild it if someone else broke in and took it apart too? * Automatic changelog generation for PR tgstation#55264 [ci skip] * Make unit tests visible to linter and IDE (tgstation#55270) * Fixes newfood reagent transfer and food trash' to_chat (tgstation#55150) Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> * Automatic changelog generation for PR tgstation#55150 [ci skip] * You can('t) whisper into comms in crit. (tgstation#54970) * Stops critted people from speaking into the radio. * Whitelist implementation and removal of unreachable/unused code. * Woops. * Automatic changelog generation for PR tgstation#54970 [ci skip] * Calms down the linter. (tgstation#55312) * Makes fearless trait affect social anxiety (tgstation#55284) An oversight from when I added psicodine and happiness * Automatic changelog generation for PR tgstation#55284 [ci skip] * Fixes perspective of mood messages (tgstation#55290) * Automatic changelog generation for PR tgstation#55290 [ci skip] * Fixes new players harddeling when the player logs out (tgstation#55295) * Fixes the lipstick sprites (tgstation#55281) * Extends the IC chat filter to be checked in two major renaming procs (tgstation#55217) About The Pull Request Honestly, I'm not sure this is the... Correct solution? But people more familiar with this will likely show me da wae. Prohibits creating names that can't actually be spoken in-character due to chat filters by adding CHAT_FILTER_CHECKs to the procs that handle sanitising them. For admin-utilised renaming procs, they'll be given a simple alert box to warn them their chosen name contains words prohibited by the IC chat filter and be allowed to confirm or cancel out. Why It's Good For The Game If you can't speak the name IC, chances are the name shouldn't be allowed at all. Players may occasionally be forced to ahelp certain names because they contain words prohibited in chat filters. * Automatic changelog generation for PR tgstation#55217 [ci skip] * 'cause it shouldn't happen (tgstation#55288) * Automatic changelog generation for PR tgstation#55288 [ci skip] * Automatic changelog compile, [ci skip] * new dark gygax sprites (cool and edgy) (tgstation#55293) new dark gygax sprites * Automatic changelog generation for PR tgstation#55293 [ci skip] * Update TGS DMAPI (tgstation#55323) Co-authored-by: tgstation-server <tgstation-server@users.noreply.github.com> * Automatic changelog compile, [ci skip] * Adds amputation shear suicide (tgstation#55308) * part 1 * now works * uhhuh * and i oop * snip snip * SNIP SNIP Co-authored-by: Coffee <crashkray@gmail.coom> * Automatic changelog generation for PR tgstation#55308 [ci skip] * Fixes borg upgrades with action buttons being broken (tgstation#55305) Fixes tgstation#55257 You can probably also currently install upgrades somehow stuck to your hand, and if so this would also fix that. * Automatic changelog generation for PR tgstation#55305 [ci skip] * Automatic changelog compile, [ci skip] * Automatic changelog compile, [ci skip] * fixes nanodrug unused sprite (tgstation#55300) NanoDrug Plus has a distinct sprite to NanoMed Plus. It isn't used. This uses it. * Automatic changelog generation for PR tgstation#55300 [ci skip] * Make RCD suicide place wall and gib user (tgstation#55283) * Make RCD suicide place wall * gibbing should return MANUAL_SUICIDE * return SHAME if no ammo * Only set RCD to wall if the message says so * Automatic changelog generation for PR tgstation#55283 [ci skip] Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Maurukas <66576896+Maurukas@users.noreply.github.com> Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> Co-authored-by: Qustinnus <Floydje123@hotmail.com> Co-authored-by: Changelogs <action@github.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: prodirus <44090982+prodirus@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com> Co-authored-by: Bond <58570888+TheBonded@users.noreply.github.com> Co-authored-by: antropod <antropod@gmail.com> Co-authored-by: Yenwodyah <yenwodyah@gmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Coffee <CoffeeDragon16@gmail.com> Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com> Co-authored-by: NightRed <nightred@gmail.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com> Co-authored-by: LordVollkorn <66637090+LordVollkorn@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: tattlemothe <66640614+dragomagol@users.noreply.github.com> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com> Co-authored-by: Cartographer-D <63861499+Cartographer-D@users.noreply.github.com> Co-authored-by: Josh <josh@jaw.sh> Co-authored-by: Coffee <crashkray@gmail.coom> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Mordent <62817778+mordent-goonstation@users.noreply.github.com> Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: Tad Hardesty <tad@platymuus.com> Co-authored-by: Winter Flare <7543955+Owai-Seek@users.noreply.github.com> Co-authored-by: WarlockD <warlockd@gmail.com> Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: tgstation-server <tgstation-server@users.noreply.github.com> Co-authored-by: Jack LeCroy <3073035+jacklecroy@users.noreply.github.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Mickyan <38563876+Mickyan@users.noreply.github.com> Co-authored-by: Tom <tomforde4@gmail.com> Co-authored-by: sergeirocks100 <31294280+sergeirocks100@users.noreply.github.com> Co-authored-by: Urumasi <Urumasi@email.cz>
NamelessFairy
pushed a commit
to NamelessFairy/tgstation
that referenced
this issue
Dec 5, 2020
Partiallyfixes tgstation#34369 Modified xenomorph, monkey, dog, and parrot strip menu UI to be like humanoids'. Also fixed an issue with parrot strip menu where it wouldn't refresh once you removed its headset, and fixed an inconsistency where human handcuff/legcuff removal buttons were different.
|
Closed (properly) by #57889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So I had cuffed this xenomorph while preforming an arrest (as you do), and later on when I went to remove her cuffs via dragging her sprite to mine, her inventory looked like it used some older outdated UI rather than the one we see when viewing other humans inventories. Still worked fine but was kinda strange.
The text was updated successfully, but these errors were encountered: