Singularity turns the ice floor into metal rods in ice box #51470
Labels
Bug
Correct Functionality
Milestone
Comments
|
Ahhhhhhhhhhhhhhhhh someone should make the tile return contingent on the tile being ripped up |
esainane
added a commit
to esainane/tgstation
that referenced
this issue
Oct 25, 2021
Turfs have a variable, intact, used to determine whether the wires and other underfloor pieces on the turf are visible, whether the underfloor pieces on the turf can be interacted with, and also whether there is anything above plating. When plating is hit with a stack of tiles, /turf/open/floor/attackby checks whether the turf is intact, and if so, ends the attack chain regardless of whether or not the attempt to hotswap a turf (with a crowbar) is successful or not. However, turfs which want the underfloor to be visible - such as catwalks and glass - set the intact variable to FALSE, and so can be repeatedly placed over one another, as if they were the first tile to be placed over the plating. This refactors /turf/var/intact into two distinct variables: - /turf/var/overfloor_placed, for whether or not there is something over plating. - /turf/var/underfloor_visible, for whether or not the various underfloor pieces should be invisible, visible, or both visible and interactable. All references to /turf/var/intact have been replaced with an equivalent overfloor_placed or underfloor_visible reference, depending on which check is appropriate. Fixes tgstation#38285. Fixes tgstation#50681. Fixes tgstation#51470. Fixes tgstation#61192. Fixes tgstation#62068. Fixes tgstation#62212. Fixes tgstation#62236.
esainane
added a commit
to esainane/tgstation
that referenced
this issue
Oct 25, 2021
Turfs have a variable, intact, used to determine whether the wires and other underfloor pieces on the turf are visible, whether the underfloor pieces on the turf can be interacted with, and also whether there is anything above plating. When plating is hit with a stack of tiles, /turf/open/floor/attackby checks whether the turf is intact, and if so, ends the attack chain regardless of whether or not the attempt to hotswap a turf (with a crowbar) is successful or not. However, turfs which want the underfloor to be visible - such as catwalks and glass - set the intact variable to FALSE, and so can be repeatedly placed over one another, as if they were the first tile to be placed over the plating. This refactors /turf/var/intact into two distinct variables: - /turf/var/overfloor_placed, for whether or not there is something over plating. - /turf/var/underfloor_accessibility, for whether or not the various underfloor pieces should be invisible, visible, or both visible and interactable. All references to /turf/var/intact have been replaced with an equivalent overfloor_placed or underfloor_accessibility check, depending on which check is appropriate. Fixes tgstation#38285. Fixes tgstation#50681. Fixes tgstation#51470. Fixes tgstation#61192. Fixes tgstation#62068. Fixes tgstation#62212. Fixes tgstation#62236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Round ID: 138854
Testmerges:
Server-Side Code Modifications: https://tgstation13.org/parsed-logs/basil/server_side_modifications.dm
Round ID: 138854
BYOND Version: 513.1522
Server revision compiled on:
Master commit: f9af519
The following pull requests are currently test merged:
#51416: 'Revert "TGS chat usage cleanup"' by MrStonedOne at commit f72c728
#50981: 'Completely disables papercode' by optimumtact at commit c21fde5
#51453: 'Fixes turf atmos getting deleted.' by nemvar at commit 075eadf
Local commit: be12b2d5e1e184809cc2b67246b92fc434ab6ccd
TGS version: /tg/station 13 Server v3.2.6.2
DMAPI version: 3.2.1.0
Reproduction:
(Picture for reference: https://gyazo.com/a9587244ff3e5b0eaaffc5d4108a4bfa )
The text was updated successfully, but these errors were encountered: