Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walking over oil stains with riot armor on bloodies it #56057

Closed
githubuser4141 opened this issue Jan 9, 2021 · 4 comments
Closed

Walking over oil stains with riot armor on bloodies it #56057

githubuser4141 opened this issue Jan 9, 2021 · 4 comments
Labels
Bug Correct Functionality Cleanup Flagged We didn't check but we think these probably don't apply anymore FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former Tested/Reproduced There might be a hope in hell of getting this fixed.

Comments

@githubuser4141
Copy link

Testmerges: #55913 #55926

Reproduction: Don a suit of riot armor, find a patch of oil OR blood on the ground, walk over it wearing jack boots and riot armor.

Description:

Keeping your set of riot armor shiny and clean is very difficult as walking over oil stains (even when wearing footwear) will cause the armor to become bloodied.

@Dorsisdwarf Dorsisdwarf added Bug Correct Functionality FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former labels Jan 9, 2021
@Tlaltecuhtli
Copy link
Contributor

step 1 cover yourself in oil

@ghost
Copy link

ghost commented Jan 9, 2021

Failed to reproduce on local server with riot suit from armory, roundstart sec jackboots and all types of CLEANABLE/oil.
Succesfully reproduced with same clothing and actual blood from an actual human mob, both bootprints and the stain itself.
Succesfully reproduced with many different shoe types and both sec and atmos hardsuit.
Failed to reproduce with a shoe type that caused this to occur with the atmos suit and a bulletproof armor.

Conclusion: this seems to be an intended behavior of exosuits that cover your shoes. The only buggy behavior here is the fact that the exosuit doesn't prevent the shoes from becoming bloody and possibly the oil thing if it does in fact occur.

P.S. Upon further testing I succesfully reproduced this in the original situation. Some bootprints can cause the exosuit and boots to become bloody. This will always occur with a given footpint decal but only some footprint decals do it.
The difference between the bloodying and non-bloodying prints seems to be the presence of forensics data in datum_components and comp_lookup. Both types are /obj/effect/decal/cleanable/blood/footprints.

The rightmost var editing window is for a non-bloodying stain. The other ones are for stains that get blood on you.
bloodyoil

@Dorsisdwarf Dorsisdwarf added the Tested/Reproduced There might be a hope in hell of getting this fixed. label Jan 10, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Forgot to mention: those were oil bootprints.

@TheBonded
Copy link
Contributor

fixed by #57085, probably

@TheBonded TheBonded added the Cleanup Flagged We didn't check but we think these probably don't apply anymore label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Correct Functionality Cleanup Flagged We didn't check but we think these probably don't apply anymore FUCK Only two things are infinite, the universe and human stupidity, and I'm not sure about the former Tested/Reproduced There might be a hope in hell of getting this fixed.
Projects
None yet
Development

No branches or pull requests

4 participants