Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Revert move type refactor, fixing the constant server crashes #55913

Closed
wants to merge 1 commit into from
Closed

[DNM] Revert move type refactor, fixing the constant server crashes #55913

wants to merge 1 commit into from

Conversation

Mothblocks
Copy link
Member

@Mothblocks Mothblocks commented Jan 2, 2021 •
edited

Disabling gravity causes too many parallel animations, crashing the server.

Someone else can figure out how to fix this (Lemon seems to want to), but I would just like to stop being pinged for being a key holder, it's discrimination.

Reverts #55444

@Mothblocks Mothblocks added the Test Merge Candidate You're our unpaid test team label Jan 2, 2021
@tgstation-server tgstation-server added Do Not Merge You must have really upset someone Refactor Makes the code harder to read Revert We all have regrets, but few get to make them vanish like this and removed Test Merge Candidate You're our unpaid test team labels Jan 2, 2021
@Mothblocks Mothblocks added the Test Merge Candidate You're our unpaid test team label Jan 2, 2021
@Cyberboss Cyberboss added the Priority: High We messed up. label Jan 2, 2021
@optimumtact
Copy link
Member

you signed up for CBT, now you get it and you look away?

@LemonInTheDark
Copy link
Member

Most likely related #55912

@LemonInTheDark
Copy link
Member

Also way to throw me under the bus

@sqnztb
Copy link
Contributor

sqnztb commented Jan 3, 2021

Most likely related #55912

Amusingly, I posted the bug report right before the testmerge hit and, yes, it does fix the issue.

@MrStonedOne
Copy link
Member

what pr does this revert?

@optimumtact
Copy link
Member

the move type refactor

@MrStonedOne
Copy link
Member

@Jared-Fogle could you add #55444 to the pr op so people know what pr this reverts.

@tgstation-server tgstation-server removed the Test Merge Candidate You're our unpaid test team label Jan 3, 2021
@Cyberboss Cyberboss added RED LABEL This PR will not auto stale, this label should be green at all times. Test Merge Candidate You're our unpaid test team labels Jan 5, 2021
@githubuser4141 githubuser4141 mentioned this pull request Jan 9, 2021
Closed
@Mothblocks
Copy link
Member Author

Fix has been merged.

@Mothblocks Mothblocks closed this Jan 10, 2021
@sqnztb sqnztb mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone Awaiting requested review from ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone is a code owner

@ninjanomnom ninjanomnom Awaiting requested review from ninjanomnom

Assignees
No one assigned
Labels
Do Not Merge You must have really upset someone Priority: High We messed up. RED LABEL This PR will not auto stale, this label should be green at all times. Refactor Makes the code harder to read Revert We all have regrets, but few get to make them vanish like this Test Merge Candidate You're our unpaid test team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Mothblocks @optimumtact @LemonInTheDark @sqnztb @MrStonedOne @Cyberboss @tgstation-server