Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kudzu / space vines stop spreading a few seconds after planted (with runtimes!) #64080

Closed
Angustmeta opened this issue Jan 13, 2022 · 4 comments · Fixed by #64306
Closed

Kudzu / space vines stop spreading a few seconds after planted (with runtimes!) #64080

Angustmeta opened this issue Jan 13, 2022 · 4 comments · Fixed by #64306
Labels
Bug Correct Functionality Runtime They multiply like cats

Comments

@Angustmeta
Copy link
Contributor

Angustmeta commented Jan 13, 2022

Observed on Terry today, and reproduced locally.

220114 0006 45

Reproduction:

  1. Plant a kudzu seed on ground.

Result: It stops spreading after a few moments. If you destroy the borders it regrows only what you destroyed. Then it starts throwing runtimes every couple of seconds (see runtime 2 below).

This could NOT be reproduced on my build from Jan 12, 2022, where #63812 was merged, so that PR is likely NOT to blame. Kudzu did still throw other runtimes on that build however, after mutating.

This non-spread bug could be reproduced after updating late Jan 13, 2022. Meaning the problem is likely caused by a very recent merge.

Runtimes:

Runtime 1 - Some time after planting [00:07:51] Runtime in spacevine.dm,569: Cannot execute null.Enter().

proc name: spread (/obj/structure/spacevine/proc/spread)
src: the space vine (/obj/structure/spacevine)
src.loc: null
call stack:
the space vine (/obj/structure/spacevine): spread()
/datum/spacevine_controller (/datum/spacevine_controller): process(2)
Objects (/datum/controller/subsystem/processing/obj): fire(0)
Objects (/datum/controller/subsystem/processing/obj): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop()
Master (/datum/controller/master): StartProcessing(0)

Runtime 2 - Spams after destroying all kudzu except one tile, I think 00:13:13] Runtime in spacevine.dm,517: Cannot read null.mutations
Another error, also seen on the build from January 12, 2022.

TESTING: GC: -- [0x2005bcb] | /obj/structure/spacevine was unable to be GC'd --

@the-orange-cow
Copy link
Contributor

Saw this same thing happen just now on Round # 176551.

@LemonInTheDark
Copy link
Member

likely my fault somehow

@Mooshimi Mooshimi added Runtime They multiply like cats Bug Correct Functionality labels Jan 14, 2022
@ShizCalev
Copy link
Member

@LemonInTheDark
Copy link
Member

Oh fuck I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Correct Functionality Runtime They multiply like cats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants