Fixes kudzu not spreading much #64306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I touched kudzu code in my harddel pr f8aad14 (tgstation#63877) I was trying to prevent the queue_end list holding onto a ref of something that was deleted from the growth_queue list mid process To achive this, I made queue_end a var on the vine controller itself. In my hubris however I neglected to **clear** it when the process was completed. So it would just keep slowly ballooning in size. This caused the kudzu to not spread at all, and also lead to harddels, kinda defeating the point of the change. This rectifies that issue
LemonInTheDark
added
GBP: No Update
tgstation-server
added
the
Fix
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
When I touched kudzu code in my harddel pr f8aad14 (#63877) I was trying to
prevent the queue_end list holding onto a ref of something that was deleted from the growth_queue list mid
process
To achieve this, I made queue_end a var on the vine controller itself. In my hubris however I neglected to
clear it when the process was completed. So it would just keep slowly ballooning in size. This caused the
kudzu to not spread at all, and also lead to harddels, kinda defeating the point of the change.
This rectifies that issue
Why It's Good For The Game
Fixes #64091
Fixes #64080
Changelog
馃啈
fix: Kudzu will spread properly now
/:cl: