Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly refinery can eject live bombs #66635

Closed
iprice opened this issue May 1, 2022 · 2 comments · Fixed by #66647
Closed

Anomaly refinery can eject live bombs #66635

iprice opened this issue May 1, 2022 · 2 comments · Fixed by #66647

Comments

@iprice
Copy link
Contributor

iprice commented May 1, 2022

Reporting client version: 514.1583

Round ID:

182417

Testmerges:

Reproduction:

This is a race condition so some speed/timing is necessary. I suspect the original case I witnessed more likely had two people hitting the button in a short space of time, but I managed to reproduce it with just myself.

Spawn a /obj/machinery/research/anomaly_refinery
Spawn a /obj/item/raw_anomaly_core/pyro
Spawn a /obj/effect/spawner/newbomb/tritium (( /plasma one seems harder to trigger. or i just had bad luck, failed with plasma 3 times, worked first time with trit. but also such are race conditions. ))
Shove the anomaly core and bomb into the refinery
Spam the implode button

If you get the timing right you can trigger this:

You insert the tank transfer valve into the anomaly refinery
You insert the raw pyro core into the anomaly refinery.
The anomaly refinery beeps, "Beginning compression test. Opening transfer valve."
ADMIN LOG: Bomb valve opened in Thunderdome Arena (168,48,1) (JMP)

The bomb's most recent set of fingerprints indicate it was last touched by Iain0/(Bob Stange)(?) (FLW)

The anomaly refinery beeps, "ERROR: Transfer valve malfunctioning. Items ejected."
The anomaly refinery beeps, "ERROR: Missing equpment. Items ejected."
ADMIN LOG: Explosion with size (Devast: 5, Heavy: 10, Light: 20, Flame: 0) in Thunderdome Arena (168,48,1) (JMP). Possible cause: the oxygen tank. Last fingerprints: null(?) (FLW).
Your eyes sting a little.
Bob Stange has died at Thunderdome Arena.
You have died. Barring complete bodyloss, you can in most cases be revived by other players. If you do not wish to be brought back, use the "Do Not Resuscitate" verb in the ghost tab.
You feel slightly disoriented. That's normal when you're just a brain.

And seen originally in round 182417

(F) [Common] The anomaly refinery beeps, "Beginning compression test. Opening transfer valve."
ADMIN LOG: Bomb valve opened in Ordnance Mixing Launch Site (134,75,2) (JMP)

The bomb's most recent set of fingerprints indicate it was last touched by Madrus/(Key Phillip)(?) (FLW)

(F) [Common] The anomaly refinery beeps, "ERROR: Transfer valve malfunctioning. Items ejected."
ADMIN LOG: Explosion with size (Devast: 1, Heavy: 3, Light: 7, Flame: 0) in Ordnance Mixing Launch Site (134,75,2) (JMP). Possible cause: the plasma tank. Last fingerprints: ahmadsan/(Derek Conrad)(?) (FLW).
(F) [Common] The tachyon-doppler array states coldly, "Explosive disturbance detected."
(F) [Common] The tachyon-doppler array states coldly, "Epicenter at: grid (134, 75). Temporal displacement of tachyons: 0 seconds."
(F) [Common] The tachyon-doppler array states coldly, "Factual: Epicenter radius: 1. Outer radius: 3. Shockwave radius: 7."

The co-ordinates 134,75,2 are the (former) location of the anomaly refinery on metastation.

@TemporalOroboros
Copy link
Contributor

It probably doesn't have enything to do with the bomb mix. Tanks explode if they are overpressurized when they process and they have a tick rate of of every two seconds. You basically have anywhere between no time and two seconds for the machine to eject the bomb.

@TemporalOroboros
Copy link
Contributor

Yeah. Starting the test doesn't actually check if a test is ongoing. Starting the test also puts the compressor into a state where attempting to start the test again will make it end the current test early. End result is if you try to start the test twice before the bomb explodes it will eject a live TTV.

Honestly want to make this an EMAG thing.

tralezab pushed a commit that referenced this issue May 8, 2022
…eone tries to use it. (#66647)

Fixes #66635 and moves the behavior behind emagging. It's funny, but probably shouldn't be something you can do by accident simply by spamming the start compression button.
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this issue Mar 12, 2023
…le-press of the button (tgstation#758)

* Makes tablets get names when not spawned on the belt (tgstation#66524)

* Emagging the anomaly compressor will eject the bomb the next time someone tries to use it. (tgstation#66647)

Fixes tgstation#66635 and moves the behavior behind emagging. It's funny, but probably shouldn't be something you can do by accident simply by spamming the start compression button.

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants