Tram STILL has two circuit labs and two cargo ordering consoles #68459
Labels
Mapping
This map needs better tile-placing. Issue only label.
Comments
MrMelbert
added
the
Mapping
|
@MrMelbert it's not just science's shutters, all the shutters on the station got reverted by someone who edited it without directional shutters |
|
Issue with shutters should be fixed with #68464. |
orthography
added a commit
to orthography/tgstation
that referenced
this issue
Jul 18, 2022
san7890
pushed a commit
that referenced
this issue
May 4, 2023
…apped onto each station map (#74985) ## About The Pull Request Inspired by #74967 and #68459 , and the fact that Tramstation regresses very often - Adds a unit test, `required_map_items`, which ensures that certain typepaths which should definitely be mapped onto every map is mapped onto every map It can also be used to ensure that items which should not be mapped in multiple times are not, among other things. I included a few examples - - Min 1, max inf of each head of staff stamps - Min 1, max 1 departmental order consoles - Min 1, max inf comms console - Min 1, max 1 Pun Pun - Min 1, max 1 Poly - Min 1, max 1 Ian If, in the future, a mapper decides they (for some reason) do not want a certain previously-required item on their map, the test can be adjusted such that it allows excluding or something, but currently it should be for items which require conscious thought about. #### QA: Why not make this a linter? I attempted to make this a linter before realizing two things 1. Someone might make a spawner which spawns the items, or they might get placed in a locker, in any case this accounts for everything on init 2. Linters run on every map, non-station maps included So I went with a test ## Why It's Good For The Game #50468 #61013 #74967 Why is it always the CMO stamp? ## Changelog Not necessary (unless I find a map missing something, then this will be updated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction:
Despite #68073 being resolved, nothing was changed.
(Bonus issue: Sci starts without a stack of glass like on other maps to do experiments with)
(Bonus bonus issue but science's shutters aren't directional yet)The text was updated successfully, but these errors were encountered: