Space Piano will NOT play G# (steps to fix included)

[sararar]

Revision:

Server:
Yogstation

Problem Description:
The note G# does not work when put into the space piano.

What did you expect to happen?
I expected the piano to play the Ab file of the same octave. (For those not musically inclined, A flat and G sharp are the same note. The sound files for this game only uses naturals and flats)

What happened instead?
When the piano was meant to play G#, it didn't play anything.

Why is this bad/What are the consequences?
If you want to code a song that uses G#, you have to put Ab instead, which is just annoying since any “proper” As in the piece are likely to need to be natural or sharp. Or, you can code the song properly and have missing notes that just make it sound wrong.

Steps to reproduce the problem:

1. Paste “C#5,D#5,E#5,F#5,G#5,A#5,B#5,C6” into the space piano. (Lower the tempo for easier listening)
2. Hit play, and hear all the notes play except G#. (Can use www.onlinepianist.com/virtual_piano/ to confirm correct notes are being played)
3. Wonder why it didn’t play G#.

Possibly related stuff:
The .dm file contains this bit of code to handle converting G#

else if(acc == "#") // mass convert all sharps to flats, octave jump already handled
    acc = "b"
    note++

If you read that you can see that if I put in, say, A#, it’s going to play the next higher note as a flat: Bb. However the notes are numbered 1-7 with G being 7. This means if you put in G#, the space piano will try to play note 8 as a flat, when there is no note 8.

This can be fixed by changing the code as follows:

else if(acc == "#" && (note == 7)) //G#
    note = 1
    acc = "b"
else if(acc == "#") // mass convert all sharps to flats, octave jump already handled
    acc = "b"
    note++

The appropriate .dm file is found at code/game/objects/structures/musician.dm
I’ve tested this change and it works exactly the way it’s supposed to.

Anything else?
Please, please use my—or another—fix since I love coding songs for the space piano <3
I would make a pull request but I'm not entirely sure how or if I even can, so hopefully someone will spot this and correct the code :)

[sararar]

Resolved. this can be closed now <3