Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can put an off hand into a bag of holding. #82019

Closed
Sadboysuss opened this issue Mar 15, 2024 · 4 comments · Fixed by #82132
Closed

You can put an off hand into a bag of holding. #82019

Sadboysuss opened this issue Mar 15, 2024 · 4 comments · Fixed by #82132
Labels
Bug Correct Functionality Tested/Reproduced There might be a hope in hell of getting this fixed.

Comments

@Sadboysuss
Copy link
Contributor

Issue Summary

You can put an Off-hand into a bag of holding. I don't know how to explain this so just watch the video.

Round ID:

reported on fulpstation codebase: https://github.com/fulpstation

Testmerges:

Fulpstation.
fulpstation/fulpstation#1107
fulpstation/fulpstation#1145
fulpstation/fulpstation#1146
fulpstation/fulpstation#1153
fulpstation/fulpstation#1156

Reproduction:

https://imgur.com/a/PiQtkPa
@Iamgoofball
Copy link
Contributor

why didnt you file this at fulpstation

@Sadboysuss
Copy link
Contributor Author

why didnt you file this at fulpstation

fulpstation is a downstream of /tg/ and I don't think this is caused by fulpstation codebase edits

@Rhials
Copy link
Contributor

Rhials commented Mar 15, 2024

Problem reproduced with same steps as in the imgur video on tg master.

it works

This is being reported in the correct place.

@ArcaneMusic ArcaneMusic added Bug Correct Functionality Tested/Reproduced There might be a hope in hell of getting this fixed. labels Mar 15, 2024
@remove32
Copy link
Contributor

i think that even though you are right about the location of the issue report, you should also take a minute to replicate the bug in tg master before submitting. including fulp info here isn't exactly helpful and could be avoided without issue by simply replicating it in a local instance. that being said, good find this is very funny

@SyncIt21 SyncIt21 mentioned this issue Mar 20, 2024
Merged
san7890 pushed a commit that referenced this issue Mar 26, 2024
@SyncIt21 @MrMelbert
Storage items won't hold abstract/hologram items (#82132)
33234b5 
## About The Pull Request
- Fixes #82019

Yeah you can't put stuff that don't exist inside storage items that
actually exist.

## Changelog
:cl:
fix: abstract(like the dual hand thingy on your hand) & hologram things
can't be put inside storage items
/:cl:

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Correct Functionality Tested/Reproduced There might be a hope in hell of getting this fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storage items won't hold abstract/hologram items SyncIt21/The-TG-Station-Fork
5 participants
@Iamgoofball @remove32 @Rhials @ArcaneMusic @Sadboysuss